Recently I ran into the following issue:
./update_test_checks.py /path/not-existing-file.ll
The script was silent and I was suprised why the real test file hadn't been updated.
Solution:
Emit warning if we detect this problem.
Differential D64572
[UpdateTestChecks] Emit warning when invalid test paths xbolva00 on Jul 11 2019, 9:26 AM. Authored by
Details Recently I ran into the following issue: ./update_test_checks.py /path/not-existing-file.ll The script was silent and I was suprised why the real test file hadn't been updated. Solution:
Diff Detail Event TimelineComment Actions Do you think hard error is better? I switched to warning since if somebody use ./update_test_checks.py fileA fileB fileC and fileC does not exists, the script will exit. New behaviour, we process fileA and fileB and we emit warnign for fileC. |