This is an archive of the discontinued LLVM Phabricator instance.

Differential D64531

[NFC] Adjust "invalid.ll.bc" tests to check for AttrKind #255 not #63
ClosedPublic

Authored by jdoerfert on Jul 10 2019, 2:20 PM.

Details

Reviewers
hfinkel
arsenm
lebedev.ri
Commits
rG24830ea71081: [NFC] Adjust "invalid.ll.bc" tests to check for AttrKind #255 not #63
rL365722: [NFC] Adjust "invalid.ll.bc" tests to check for AttrKind #255 not #63
Summary

We are about to add enum attributes with AttrKind numbers >= 63. This
means we cannot use AttrKind #63 to test for an invalid attribute number
in the RAW format anymore. This patch changes the number of an invalid
attribute to #255. There is no change to the character of the tests.

Diff Detail

Repository
rL LLVM

Event Timeline

jdoerfert created this revision.Jul 10 2019, 2:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 2:20 PM
Herald added subscribers: dexonsmith, steven_wu, bollu and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B34716: Diff 209067.Jul 10 2019, 2:21 PM
lebedev.ri accepted this revision.Jul 10 2019, 2:26 PM

I have no context here, but this roughly matches what had previously happened to these lines, so should be fine i guess?

This revision is now accepted and ready to land.Jul 10 2019, 2:26 PM
Closed by commit rL365722: [NFC] Adjust "invalid.ll.bc" tests to check for AttrKind #255 not #63 (authored by jdoerfert). · Explain WhyJul 10 2019, 6:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
Bindings/
llvm-c/
Inputs/
4 lines
Bitcode/
2 lines
LTO/
X86/
Inputs/
2 lines

Diff 209109

llvm/trunk/test/Bindings/llvm-c/Inputs/invalid.ll.bc

  • This is a binary file.

llvm/trunk/test/Bindings/llvm-c/invalid-bitcode.test

; RUN: not llvm-c-test --module-dump < %S/Inputs/invalid.ll.bc 2>&1 | FileCheck %s ; RUN: not llvm-c-test --module-dump < %S/Inputs/invalid.ll.bc 2>&1 | FileCheck %s
; RUN: not llvm-c-test --lazy-module-dump < %S/Inputs/invalid.ll.bc 2>&1 | FileCheck %s ; RUN: not llvm-c-test --lazy-module-dump < %S/Inputs/invalid.ll.bc 2>&1 | FileCheck %s
CHECK: Error parsing bitcode: Unknown attribute kind (63) CHECK: Error parsing bitcode: Unknown attribute kind (255)
; RUN: not llvm-c-test --new-module-dump < %S/Inputs/invalid.ll.bc 2>&1 | FileCheck --check-prefix=NEW %s ; RUN: not llvm-c-test --new-module-dump < %S/Inputs/invalid.ll.bc 2>&1 | FileCheck --check-prefix=NEW %s
; RUN: not llvm-c-test --lazy-new-module-dump < %S/Inputs/invalid.ll.bc 2>&1 | FileCheck --check-prefix=NEW %s ; RUN: not llvm-c-test --lazy-new-module-dump < %S/Inputs/invalid.ll.bc 2>&1 | FileCheck --check-prefix=NEW %s
NEW: Error with new bitcode parser: Unknown attribute kind (63) NEW: Error with new bitcode parser: Unknown attribute kind (255)
; RUN: llvm-c-test --test-diagnostic-handler < %S/Inputs/invalid.ll.bc 2>&1 | FileCheck --check-prefix=DIAGNOSTIC %s ; RUN: llvm-c-test --test-diagnostic-handler < %S/Inputs/invalid.ll.bc 2>&1 | FileCheck --check-prefix=DIAGNOSTIC %s
DIAGNOSTIC: Executing diagnostic handler DIAGNOSTIC: Executing diagnostic handler
DIAGNOSTIC: Diagnostic severity is of type error DIAGNOSTIC: Diagnostic severity is of type error
DIAGNOSTIC: Diagnostic handler was called while loading module DIAGNOSTIC: Diagnostic handler was called while loading module

llvm/trunk/test/Bitcode/invalid.ll

; RUN: not llvm-dis < %s.bc 2>&1 | FileCheck %s ; RUN: not llvm-dis < %s.bc 2>&1 | FileCheck %s
; CHECK: llvm-dis{{(\.EXE|\.exe)?}}: error: Unknown attribute kind (63) ; CHECK: llvm-dis{{(\.EXE|\.exe)?}}: error: Unknown attribute kind (255)
; invalid.ll.bc has an invalid attribute number. ; invalid.ll.bc has an invalid attribute number.
; The test checks that LLVM reports the error and doesn't access freed memory ; The test checks that LLVM reports the error and doesn't access freed memory
; in doing so. ; in doing so.

llvm/trunk/test/Bitcode/invalid.ll.bc

  • This is a binary file.

llvm/trunk/test/LTO/X86/Inputs/invalid.ll.bc

  • This is a binary file.

llvm/trunk/test/LTO/X86/invalid.ll

; RUN: not llvm-lto %S/Inputs/invalid.ll.bc 2>&1 | FileCheck %s ; RUN: not llvm-lto %S/Inputs/invalid.ll.bc 2>&1 | FileCheck %s
; CHECK: llvm-lto{{.*}}: error loading file '{{.*}}/Inputs/invalid.ll.bc': Unknown attribute kind (63) ; CHECK: llvm-lto{{.*}}: error loading file '{{.*}}/Inputs/invalid.ll.bc': Unknown attribute kind (255)