Page MenuHomePhabricator

[Driver] Don't pass --dynamic-linker to ld on Solaris
ClosedPublic

Authored by ro on Jul 10 2019, 7:13 AM.

Details

Summary

I noticed that clang currenly passes --dynamic-linker to ld. This has been the case
since Solaris 11 support was added initially back in 2012 by David Chisnall (r150580).
I couldn't find any patch submission, let alone a justification, for this, and it seems
completely useless: --dynamic-linker is a gld compatibility form of the option, the
native option being -I. First of all, however, the dynamic linker passed is simply the
default, so there's no reason at all to specify it in the first place.

This patch removes passing the option and adjusts the affected testcase accordingly.

Tested on x86_64-pc-solaris2.11 and sparcv9-sun-solaris2.11. Ok for trunk?

Diff Detail

Repository
rL LLVM

Event Timeline

ro created this revision.Jul 10 2019, 7:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 7:13 AM

Ping? It's been a ween and unless someone comes up with a good explanation why the default interpreter must be specified instead
of letting ld figure it out, this seems pretty obvious.

theraven accepted this revision.Jul 16 2019, 3:03 AM
This revision is now accepted and ready to land.Jul 16 2019, 3:03 AM

I think this was simply mirroring what gcc 4.something did on Solaris.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2019, 4:06 AM