This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] gfx908 mAI instructions, MC part
ClosedPublic

Authored by rampitec on Jul 9 2019, 2:03 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

rampitec created this revision.Jul 9 2019, 2:03 PM
arsenm added inline comments.Jul 9 2019, 2:12 PM
include/llvm/IR/IntrinsicsAMDGPU.td
1648 ↗(On Diff #208804)

Should these be speculatable?

lib/Target/AMDGPU/AMDGPURegAsmNames.inc.cpp
353 ↗(On Diff #208804)

We should probably get around to making tablegen produce these tables

lib/Target/AMDGPU/SIInstrFormats.td
125 ↗(On Diff #208804)

It's not obvious to me what MAI stands for

rampitec marked 3 inline comments as done.Jul 9 2019, 2:18 PM
rampitec added inline comments.
include/llvm/IR/IntrinsicsAMDGPU.td
1648 ↗(On Diff #208804)

I do not think so. They are crosslane.

lib/Target/AMDGPU/AMDGPURegAsmNames.inc.cpp
353 ↗(On Diff #208804)

Likely. This file is growing.

lib/Target/AMDGPU/SIInstrFormats.td
125 ↗(On Diff #208804)

That is how these are called in the spec. I assume when we upload the spec it will make more sense. But generally Matrix Arithmetic ISA.

arsenm accepted this revision.Jul 9 2019, 2:23 PM
arsenm added inline comments.
lib/Target/AMDGPU/SIInstrFormats.td
125 ↗(On Diff #208804)

Should add that as a comment

This revision is now accepted and ready to land.Jul 9 2019, 2:23 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2019, 2:43 PM