This is an archive of the discontinued LLVM Phabricator instance.

Differential D64423

[OpenMP] Simplify getFloatTypeSemantics
ClosedPublic

Authored by MaskRay on Jul 9 2019, 8:55 AM.

Details

Reviewers
ABataev
Commits
rG3fbd8fda9a02: [OpenMP] Simplify getFloatTypeSemantics
rL365545: [OpenMP] Simplify getFloatTypeSemantics
rC365545: [OpenMP] Simplify getFloatTypeSemantics
Summary

When the float point representations are the same on the host and on the target device,
(&Target->getLongDoubleFormat() == &AuxTarget->getLongDoubleFormat()),
we can just use AuxTarget->getLongDoubleFormat().

Diff Detail

Event Timeline

MaskRay created this revision.Jul 9 2019, 8:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2019, 8:55 AM
Herald added subscribers: cfe-commits, jdoerfert, guansong. · View Herald Transcript
Harbormaster completed remote builds in B34608: Diff 208707.Jul 9 2019, 8:55 AM
jdoerfert added a comment.Jul 9 2019, 9:07 AM

Could we generally require some message for all reviews and commits?

ABataev accepted this revision.Jul 9 2019, 9:30 AM

LG, but I agree, some general description would be good

This revision is now accepted and ready to land.Jul 9 2019, 9:30 AM
MaskRay updated this revision to Diff 208780.Jul 9 2019, 12:35 PM
MaskRay edited the summary of this revision. (Show Details)

Update description

Harbormaster completed remote builds in B34632: Diff 208780.Jul 9 2019, 12:35 PM
Closed by commit rL365545: [OpenMP] Simplify getFloatTypeSemantics (authored by MaskRay). · Explain WhyJul 9 2019, 12:36 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2019, 12:36 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
lib/
AST/
6 lines

Diff 208780

lib/AST/ASTContext.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,519 Lines • ▼ Show 20 Linesconst llvm::fltSemantics &ASTContext::getFloatTypeSemantics(QualType T) const {
switch (BT->getKind()) { switch (BT->getKind()) {
default: llvm_unreachable("Not a floating point type!"); default: llvm_unreachable("Not a floating point type!");
case BuiltinType::Float16: case BuiltinType::Float16:
case BuiltinType::Half: case BuiltinType::Half:
return Target->getHalfFormat(); return Target->getHalfFormat();
case BuiltinType::Float: return Target->getFloatFormat(); case BuiltinType::Float: return Target->getFloatFormat();
case BuiltinType::Double: return Target->getDoubleFormat(); case BuiltinType::Double: return Target->getDoubleFormat();
case BuiltinType::LongDouble: case BuiltinType::LongDouble:
if (getLangOpts().OpenMP && getLangOpts().OpenMPIsDevice && if (getLangOpts().OpenMP && getLangOpts().OpenMPIsDevice)
&Target->getLongDoubleFormat() != &AuxTarget->getLongDoubleFormat())
return AuxTarget->getLongDoubleFormat(); return AuxTarget->getLongDoubleFormat();
return Target->getLongDoubleFormat(); return Target->getLongDoubleFormat();
case BuiltinType::Float128: case BuiltinType::Float128:
if (getLangOpts().OpenMP && getLangOpts().OpenMPIsDevice && if (getLangOpts().OpenMP && getLangOpts().OpenMPIsDevice)
&Target->getFloat128Format() != &AuxTarget->getFloat128Format())
return AuxTarget->getFloat128Format(); return AuxTarget->getFloat128Format();
return Target->getFloat128Format(); return Target->getFloat128Format();
} }
} }
CharUnits ASTContext::getDeclAlign(const Decl *D, bool ForAlignof) const { CharUnits ASTContext::getDeclAlign(const Decl *D, bool ForAlignof) const {
unsigned Align = Target->getCharWidth(); unsigned Align = Target->getCharWidth();
▲ Show 20 Lines • Show All 9,106 Lines • Show Last 20 Lines