This is an archive of the discontinued LLVM Phabricator instance.

[DFSAN][MIPS] adding support of DFSAN for MIPS64
ClosedPublic

Authored by sdkie on Nov 27 2014, 4:54 AM.

Diff Detail

Event Timeline

sdkie updated this revision to Diff 16686.Nov 27 2014, 4:54 AM
sdkie retitled this revision from to [DFSAN][MIPS] adding support of DFSAN for MIPS64.
sdkie updated this object.
sdkie edited the test plan for this revision. (Show Details)
sdkie added reviewers: pcc, kcc.
sdkie set the repository for this revision to rL LLVM.
sdkie added a subscriber: Unknown Object (MLST).
sdkie updated this revision to Diff 16687.Nov 27 2014, 5:02 AM

corrected 'kAppAddr' value

pcc added inline comments.Nov 28 2014, 4:33 PM
lib/dfsan/dfsan.h
50

I think you will need to make a similar change to LLVM (search for ShadowPtrMask in lib/Transforms/Instrumentation/DataFlowSanitizer.cpp).

pcc accepted this revision.Dec 4 2014, 2:10 PM
pcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 4 2014, 2:10 PM
sdkie added a comment.Dec 4 2014, 9:57 PM

@pcc: I don't have commit access.
Can you commit both the patches for me?

Thanks.

pcc closed this revision.Dec 5 2014, 1:23 PM
pcc updated this revision to Diff 16995.

Closed by commit rL223517 (authored by @pcc).