This is an archive of the discontinued LLVM Phabricator instance.

Differential D64158

[AMDGPU] Corrected checking for __hip_texture struct pointer in the Metadata Streamer.
AbandonedPublic

Authored by kpyzhov on Jul 3 2019, 1:35 PM.

Details

Reviewers
kzhuravl
yaxunl
a.sidorin

Diff Detail

Repository
rL LLVM

Event Timeline

kpyzhov created this revision.Jul 3 2019, 1:35 PM
Herald added a reviewer: a.sidorin. · View Herald TranscriptJul 3 2019, 1:35 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, hiraditya, t-tye and 6 others. · View Herald Transcript
kpyzhov abandoned this revision.Jul 3 2019, 2:49 PM

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
18 lines

Diff 207877

llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 LinesMetadataStreamerV2::getAddressSpaceQualifier(
} }
} }
ValueKind MetadataStreamerV2::getValueKind(Type *Ty, StringRef TypeQual, ValueKind MetadataStreamerV2::getValueKind(Type *Ty, StringRef TypeQual,
StringRef BaseTypeName) const { StringRef BaseTypeName) const {
if (TypeQual.find("pipe") != StringRef::npos) if (TypeQual.find("pipe") != StringRef::npos)
return ValueKind::Pipe; return ValueKind::Pipe;
if (isa<PointerType>(Ty) && Ty->getPointerElementType()->isStructTy() && if (isa<PointerType>(Ty)) {
Ty->getPointerElementType()->getStructName() == "struct.__hip_texture") { const Type* elType = Ty->getPointerElementType();
if (elType->isStructTy() && !cast<StructType>(elType)->isLiteral() &&
elType->getStructName() == "struct.__hip_texture") {
return ValueKind::Image; return ValueKind::Image;
} }
}
return StringSwitch<ValueKind>(BaseTypeName) return StringSwitch<ValueKind>(BaseTypeName)
.Case("image1d_t", ValueKind::Image) .Case("image1d_t", ValueKind::Image)
.Case("image1d_array_t", ValueKind::Image) .Case("image1d_array_t", ValueKind::Image)
.Case("image1d_buffer_t", ValueKind::Image) .Case("image1d_buffer_t", ValueKind::Image)
.Case("image2d_t", ValueKind::Image) .Case("image2d_t", ValueKind::Image)
.Case("image2d_array_t", ValueKind::Image) .Case("image2d_array_t", ValueKind::Image)
.Case("image2d_array_depth_t", ValueKind::Image) .Case("image2d_array_depth_t", ValueKind::Image)
▲ Show 20 Lines • Show All 422 Lines • ▼ Show 20 LinesMetadataStreamerV3::getAddressSpaceQualifier(unsigned AddressSpace) const {
} }
} }
StringRef MetadataStreamerV3::getValueKind(Type *Ty, StringRef TypeQual, StringRef MetadataStreamerV3::getValueKind(Type *Ty, StringRef TypeQual,
StringRef BaseTypeName) const { StringRef BaseTypeName) const {
if (TypeQual.find("pipe") != StringRef::npos) if (TypeQual.find("pipe") != StringRef::npos)
return "pipe"; return "pipe";
if (isa<PointerType>(Ty) && Ty->getPointerElementType()->isStructTy() && if (isa<PointerType>(Ty)) {
Ty->getPointerElementType()->getStructName() == "struct.__hip_texture") { const Type* elType = Ty->getPointerElementType();
if (elType->isStructTy() && !cast<StructType>(elType)->isLiteral() &&
elType->getStructName() == "struct.__hip_texture") {
return "image"; return "image";
} }
}
return StringSwitch<StringRef>(BaseTypeName) return StringSwitch<StringRef>(BaseTypeName)
.Case("image1d_t", "image") .Case("image1d_t", "image")
.Case("image1d_array_t", "image") .Case("image1d_array_t", "image")
.Case("image1d_buffer_t", "image") .Case("image1d_buffer_t", "image")
.Case("image2d_t", "image") .Case("image2d_t", "image")
.Case("image2d_array_t", "image") .Case("image2d_array_t", "image")
.Case("image2d_array_depth_t", "image") .Case("image2d_array_depth_t", "image")
▲ Show 20 Lines • Show All 397 Lines • Show Last 20 Lines