Page MenuHomePhabricator

[ValueTracking] Add MustPreserveNullness arg to functions analyzing calls. (NFC)
ClosedPublic

Authored by fhahn on Jul 3 2019, 10:59 AM.

Details

Summary

Some uses of getArgumentAliasingToReturnedPointer and
isIntrinsicReturningPointerAliasingArgumentWithoutCapturing require the
calls/intrinsics to preserve the nullness of the argument.

For alias analysis, the nullness property does not really come into
play.

This patch explicitly sets it to true. In D61669, the alias analysis
uses will be switched to not require preserving nullness.

Diff Detail

Repository
rL LLVM

Event Timeline

fhahn created this revision.Jul 3 2019, 10:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2019, 10:59 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
jdoerfert accepted this revision.Jul 3 2019, 11:59 AM

LGTM. One could have uses a default value (true) but making it explicit is fine with me as well.

This revision is now accepted and ready to land.Jul 3 2019, 11:59 AM
This revision was automatically updated to reflect the committed changes.