This allows us to use the analyzer from unit tests.
- Refactor the interface to use proper error handling for most functions after JF's work.
- Move everything into a BitstreamAnalyzer class.
- Move that to Bitcode/BitcodeAnalyzer.h.
Paths
| Differential D64116
[llvm-bcanalyzer] Refactor and move to libLLVMBitReader ClosedPublic Authored by thegameg on Jul 2 2019, 5:44 PM.
Details Summary This allows us to use the analyzer from unit tests.
Diff Detail Event Timelinethegameg added a parent revision: D63899: [Bitcode] Move Bitstream to a separate library.Jul 2 2019, 5:45 PM
Comment Actions LGTM, with one minor nit inline. Thanks for doing this, Francis!
This revision is now accepted and ready to land.Jul 3 2019, 3:21 PM Closed by commit rL365286: [llvm-bcanalyzer] Refactor and move to libLLVMBitReader (authored by thegameg). · Explain WhyJul 7 2019, 7:06 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 207672 llvm/include/llvm/Bitcode/BitcodeAnalyzer.h
llvm/lib/Bitcode/Reader/BitcodeAnalyzer.cpp
llvm/lib/Bitcode/Reader/CMakeLists.txt
llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
|
Given that this is now in the llvm namespace, maybe rename this to BCDumpOptions?