This is an archive of the discontinued LLVM Phabricator instance.

Add geomean column earlier to dataout as Series in compare.py.
ClosedPublic

Authored by fhahn on Jul 2 2019, 4:03 AM.

Details

Summary

This fixes the following error when using --all.

Traceback (most recent call last):

File "test-suite/utils/compare.py", line 374, in <module>
  print_result(data, limit_output, shorten_names, config.show_diff, sortkey)
File "test-suite/utils/compare.py", line 227, in print_result
  dataout = add_geomean_row(d, dataout)
File "test-suite/utils/compare.py", line 139, in add_geomean_row
  relative = values1 / values0
File "pyvenv/lib/python2.7/site-packages/pandas/core/ops.py", line 1583, in wrapper
  result = safe_na_op(lvalues, rvalues)
File "pyvenv/lib/python2.7/site-packages/pandas/core/ops.py", line 1533, in safe_na_op
  lambda x: op(x, rvalues))
File "pandas/_libs/algos.pyx", line 690, in pandas._libs.algos.arrmap
File "pyvenv/lib/python2.7/site-packages/pandas/core/ops.py", line 1533, in <lambda>
  lambda x: op(x, rvalues))

TypeError: ufunc 'true_divide' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

Event Timeline

fhahn created this revision.Jul 2 2019, 4:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2019, 4:03 AM

Any chance you could have a quick look Jessica?

paquette accepted this revision.Jul 23 2019, 2:04 PM

Sorry, I didn't get the email for this for some reason.

LGTM, thanks for fixing this!

This revision is now accepted and ready to land.Jul 23 2019, 2:04 PM
This revision was automatically updated to reflect the committed changes.