Add geomean column earlier to dataout as Series in compare.py.

[fhahn]

Summary

This fixes the following error when using --all.

Traceback (most recent call last):

File "test-suite/utils/compare.py", line 374, in <module>
  print_result(data, limit_output, shorten_names, config.show_diff, sortkey)
File "test-suite/utils/compare.py", line 227, in print_result
  dataout = add_geomean_row(d, dataout)
File "test-suite/utils/compare.py", line 139, in add_geomean_row
  relative = values1 / values0
File "pyvenv/lib/python2.7/site-packages/pandas/core/ops.py", line 1583, in wrapper
  result = safe_na_op(lvalues, rvalues)
File "pyvenv/lib/python2.7/site-packages/pandas/core/ops.py", line 1533, in safe_na_op
  lambda x: op(x, rvalues))
File "pandas/_libs/algos.pyx", line 690, in pandas._libs.algos.arrmap
File "pyvenv/lib/python2.7/site-packages/pandas/core/ops.py", line 1533, in <lambda>
  lambda x: op(x, rvalues))

TypeError: ufunc 'true_divide' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

[fhahn]

ping

[fhahn]

Any chance you could have a quick look Jessica?

[fhahn]

ping

[paquette]

Sorry, I didn't get the email for this for some reason.

LGTM, thanks for fixing this!

test-suite/trunk/utils/compare.py

def add_geomean_row(data, dataout):
     summary row to dataout.
     """
     values0, values1 = get_values(data)
     relative = values1 / values0
     gm_diff = stats.gmean(relative) - 1.0
 
     gm_row = {c: '' for c in dataout.columns}
     gm_row['diff'] = gm_diff
-    gm_row['Program'] = 'Geomean difference'
-    return dataout.append(gm_row, ignore_index=True)
+    series = pd.Series(gm_row, name='Geomean difference')
+    return dataout.append(series)
 
 def filter_failed(data, key='Exec'):
     return data.loc[data[key] == "pass"]
 
 def filter_short(data, key='Exec_Time', threshold=0.6):
     return data.loc[data[key] >= threshold]
 
 def filter_same_hash(data, key='hash'):
def print_result(d, limit_output=True, shorten_names=True,
     del d['$sortkey']
     if not show_diff_column:
         del d['diff']
     dataout = d
     if limit_output:
         # Take 15 topmost elements
         dataout = dataout.head(15)
 
-    # Turn index into a column so we can format it...
-    dataout.insert(0, 'Program', dataout.index)
-
     if show_diff_column:
-        dataout = add_geomean_row(d, dataout)
 
+    # Turn index into a column so we can format it...
+    dataout.insert(0, 'Program', dataout.index)
+
     formatters = dict()
     formatters['diff'] = format_diff
     if shorten_names:
         drop_prefix, drop_suffix = determine_common_prefix_suffix(dataout.Program)
         def format_name(name, common_prefix, common_suffix):
             name = name[common_prefix:]
             if common_suffix > 0:
                 name = name[:-common_suffix]