Page MenuHomePhabricator

[UpdateTestChecks] [ARM] Add support for armv7-apple-darwin
ClosedPublic

Authored by jsji on Jun 28 2019, 10:15 AM.

Details

Summary

armv7-apple-darwin was not supported well, the script can't generate checks.

https://reviews.llvm.org/D60601/new/#inline-568671

Also updated one of the testcases needed in https://reviews.llvm.org/D60601.

Diff Detail

Repository
rL LLVM

Event Timeline

jsji created this revision.Jun 28 2019, 10:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2019, 10:15 AM
jsji edited the summary of this revision. (Show Details)Jun 28 2019, 10:15 AM
lebedev.ri added inline comments.Jun 28 2019, 10:24 AM
llvm/test/CodeGen/ARM/ldst-f32-2-i32.ll
8 ↗(On Diff #207089)

Does filecheck not bark on this?
I think you want to skip empty lines before body

jsji marked an inline comment as done.Jun 28 2019, 10:27 AM
jsji added inline comments.
llvm/test/CodeGen/ARM/ldst-f32-2-i32.ll
8 ↗(On Diff #207089)

Good catch, will fix it.

jsji updated this revision to Diff 207096.Jun 28 2019, 10:40 AM

Update to remove unintended empty lines before body.

lebedev.ri accepted this revision.Jun 28 2019, 10:55 AM

LG. I trust that you have verified that FileCheck accepts these check lines.

This revision is now accepted and ready to land.Jun 28 2019, 10:55 AM
jsji added a comment.Jun 28 2019, 10:57 AM

LG. I trust that you have verified that FileCheck accepts these check lines.

Sure. Thanks!

This revision was automatically updated to reflect the committed changes.