This is an archive of the discontinued LLVM Phabricator instance.

Differential D63898

[WebAssembly] Enable an atomic.notify MC test
ClosedPublic

Authored by aheejin on Jun 27 2019, 2:13 PM.

Details

Reviewers
aardappel
Commits
rG24dba1fe972e: [WebAssembly] Enable an atomic.notify MC test
rL364596: [WebAssembly] Enable an atomic.notify MC test
Summary

Assembly of atomic.notify has been fixed in r364576, so we can enable
it.

Diff Detail

Repository
rL LLVM

Event Timeline

aheejin created this revision.Jun 27 2019, 2:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2019, 2:13 PM
Herald added subscribers: llvm-commits, jfb, sunfish and 3 others. · View Herald Transcript
Harbormaster completed remote builds in B34024: Diff 206934.Jun 27 2019, 2:14 PM
aardappel accepted this revision.Jun 27 2019, 2:16 PM

Remove not in the summary?

This revision is now accepted and ready to land.Jun 27 2019, 2:16 PM
aheejin added a comment.Jun 27 2019, 2:20 PM

Oh right, I don't know why it got there. Thanks!

aheejin edited the summary of this revision. (Show Details)Jun 27 2019, 2:21 PM
Closed by commit rL364596: [WebAssembly] Enable an atomic.notify MC test (authored by aheejin). · Explain WhyJun 27 2019, 2:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
MC/
WebAssembly/
5 lines

Diff 206937

llvm/trunk/test/MC/WebAssembly/atomics-encodings.s

# RUN: llvm-mc -show-encoding -triple=wasm32-unkown-unknown -mattr=+atomics < %s | FileCheck %s # RUN: llvm-mc -show-encoding -triple=wasm32-unkown-unknown -mattr=+atomics < %s | FileCheck %s
main: main:
.functype main () -> () .functype main () -> ()
# FIXME This doesn't work because of PR40728. Enable this once it's fixed. # CHECK: atomic.notify 0 # encoding: [0xfe,0x00,0x02,0x00]
# C HECK: atomic.notify 0 # encoding: [0xfe,0x00,0x00,0x00] atomic.notify 0
# atomic.notify 0
# CHECK: i32.atomic.wait 0 # encoding: [0xfe,0x01,0x02,0x00] # CHECK: i32.atomic.wait 0 # encoding: [0xfe,0x01,0x02,0x00]
i32.atomic.wait 0 i32.atomic.wait 0
# CHECK: i64.atomic.wait 0 # encoding: [0xfe,0x02,0x03,0x00] # CHECK: i64.atomic.wait 0 # encoding: [0xfe,0x02,0x03,0x00]
i64.atomic.wait 0 i64.atomic.wait 0
# CHECK: i32.atomic.load 0 # encoding: [0xfe,0x10,0x02,0x00] # CHECK: i32.atomic.load 0 # encoding: [0xfe,0x10,0x02,0x00]
i32.atomic.load 0 i32.atomic.load 0
# CHECK: i64.atomic.load 4 # encoding: [0xfe,0x11,0x03,0x04] # CHECK: i64.atomic.load 4 # encoding: [0xfe,0x11,0x03,0x04]
▲ Show 20 Lines • Show All 133 Lines • Show Last 20 Lines