This is an archive of the discontinued LLVM Phabricator instance.

Differential D63836

[llvm-ar] Document response file support in --help
ClosedPublic

Authored by sbc100 on Jun 26 2019, 12:09 PM.

Details

Reviewers
rupprecht
dschuff
Commits
rG70a8027c60fe: [llvm-ar] Document response file support in --help
rL364673: [llvm-ar] Document response file support in --help
Summary

Also a test for this.

Diff Detail

Event Timeline

sbc100 created this revision.Jun 26 2019, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2019, 12:09 PM
Herald added subscribers: llvm-commits, rupprecht, aheejin. · View Herald Transcript
Harbormaster completed remote builds in B33965: Diff 206722.Jun 26 2019, 12:09 PM
sbc100 added a reviewer: rupprecht.Jun 26 2019, 12:11 PM
sbc100 added a reviewer: dschuff.Jun 28 2019, 8:45 AM
dschuff accepted this revision.Jun 28 2019, 9:00 AM
dschuff added inline comments.
llvm/test/tools/llvm-nm/X86/importlibrary.test
1

is this change related?

This revision is now accepted and ready to land.Jun 28 2019, 9:00 AM
sbc100 marked an inline comment as done.Jun 28 2019, 11:35 AM
sbc100 added inline comments.
llvm/test/tools/llvm-nm/X86/importlibrary.test
1

No, I was just tidying up these tests that I was copying from. I can revert these two or make a separate change.

sbc100 updated this revision to Diff 207119.Jun 28 2019, 11:43 AM
  • revert part
Harbormaster completed remote builds in B34086: Diff 207119.Jun 28 2019, 11:44 AM
Closed by commit rG70a8027c60fe: [llvm-ar] Document response file support in --help (authored by sbc100). · Explain WhyJun 28 2019, 11:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-ar/
9 lines
llvm-nm/
X86/
2 lines
4 lines
tools/
llvm-ar/
1 line

Diff 206722

llvm/test/tools/llvm-ar/response-file.test

  • This file was added.
RUN: touch %t-a.txt %t-b.txt %t-c.txt
RUN: echo "rcs %t.a %t-a.txt %t-b.txt %t-c.txt" > %t-response
RUN: rm -f %t.a
RUN: llvm-ar @%t-response
RUN: llvm-ar t %t.a | FileCheck %s
CHECK: a.txt
CHECK-NEXT: b.txt
CHECK-NEXT: c.txt

llvm/test/tools/llvm-nm/X86/importlibrary.test

# RUN: llvm-nm -B %S/Inputs/example.lib | FileCheck --match-full-lines %s RUN: llvm-nm -B %S/Inputs/example.lib | FileCheck --match-full-lines %s
dschuffUnsubmitted
Not Done
ReplyInline Actions

is this change related?

dschuff: is this change related?
sbc100AuthorUnsubmitted
Done
ReplyInline Actions

No, I was just tidying up these tests that I was copying from. I can revert these two or make a separate change.

sbc100: No, I was just tidying up these tests that I was copying from. I can revert these two or make…
CHECK: 00000000 I __IMPORT_DESCRIPTOR_example CHECK: 00000000 I __IMPORT_DESCRIPTOR_example
CHECK: 00000000 I __NULL_IMPORT_DESCRIPTOR CHECK: 00000000 I __NULL_IMPORT_DESCRIPTOR
CHECK: 00000000 R __imp__constant CHECK: 00000000 R __imp__constant
CHECK: 00000000 R _constant CHECK: 00000000 R _constant
CHECK: 00000000 D __imp__data CHECK: 00000000 D __imp__data
CHECK: 00000000 T __imp__function CHECK: 00000000 T __imp__function
CHECK: 00000000 T _function CHECK: 00000000 T _function

llvm/test/tools/llvm-nm/X86/response-file.test

# RUN: echo "-P %p/Inputs/hello.obj.elf-x86_64" > %t-response RUN: echo "-P %p/Inputs/hello.obj.elf-x86_64" > %t-response
# RUN: llvm-nm @%t-response | FileCheck %s RUN: llvm-nm @%t-response | FileCheck %s
CHECK: main T 0 15 CHECK: main T 0 15
CHECK: puts U 0 0 CHECK: puts U 0 0

llvm/tools/llvm-ar/llvm-ar.cpp

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 LinesOPTIONS:
--format - Archive format to create --format - Archive format to create
=default - default =default - default
=gnu - gnu =gnu - gnu
=darwin - darwin =darwin - darwin
=bsd - bsd =bsd - bsd
--plugin=<string> - Ignored for compatibility --plugin=<string> - Ignored for compatibility
--help - Display available options --help - Display available options
--version - Display the version of this program --version - Display the version of this program
@<file> - read options from <file>
OPERATIONS: OPERATIONS:
d - delete [files] from the archive d - delete [files] from the archive
m - move [files] in the archive m - move [files] in the archive
p - print [files] found in the archive p - print [files] found in the archive
q - quick append [files] to the archive q - quick append [files] to the archive
r - replace or insert [files] into the archive r - replace or insert [files] into the archive
s - act as ranlib s - act as ranlib
▲ Show 20 Lines • Show All 1,051 Lines • Show Last 20 Lines