Page MenuHomePhabricator

[Driver] Fix style issues of --print-supported-cpus
ClosedPublic

Authored by MaskRay on Jun 26 2019, 7:16 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Jun 26 2019, 7:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2019, 7:16 AM
ziangwan added a comment.EditedJun 26 2019, 9:34 AM

Hey @MaskRay , can you explain why we should remove --print-supported-cpus. There already are similar options in clang such as --print-effective-triple and --print-libgcc-file-name. On the other hand, I almost never see an option goes like -xxx=?. Also, why can't we support both since they are just aliases to each other?

MaskRay updated this revision to Diff 206989.Jun 27 2019, 8:16 PM
MaskRay retitled this revision from [Driver] Delete --print-supported-cpus in favor of -mcpu=? or -mtune=? to [Driver] Fix style issues of --print-supported-cpus.

Repurpose

MaskRay updated this revision to Diff 206993.Jun 27 2019, 8:26 PM

Restore a comment

This revision is now accepted and ready to land.Jun 28 2019, 10:07 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2019, 6:24 PM