- User Since
- Jun 4 2019, 3:37 PM (57 w, 3 d)
Aug 7 2019
Fix style issue.
Aug 4 2019
Aug 2 2019
The two failing cases I am seeing are:
/home/motus/netbsd8/netbsd8/llvm/projects/libcxx/include/random:3648:40: error: implicit conversion from 'unsigned int' to 'float' changes value from 2147483645 to 2147483648 [-Werror,-Wimplicit-int-float-conversion] const _RealType _Rp = _URNG::max() - _URNG::min() + _RealType(1); ~~~~~~~~~~~~~^~~~~~~~~~~~~~ ~
/data/motus/netbsd8/netbsd8/llvm/projects/libcxx/test/std/numerics/rand/rand.util/rand.util.canonical/generate_canonical.pass.cpp:27:64: error: implicit conversion from 'unsigned int' to 'float' changes value from 2147483645 to 2147483648 [-Werror,-Wimplicit-int-float-conversion] assert(f == truncate_fp((16807 - E::min()) / (E::max() - E::min() + F(1)))); ~~~~~~~~~^~~~~~~~~~ ~
These are the intended behavior of this warning.
Jul 31 2019
Buildbot failed for x86_64 target. Fix in progress.
I have committed this patch. I will stay vigilant in case anything fails.
Jul 30 2019
Jul 29 2019
Jul 26 2019
Jul 25 2019
My bad. I omit these two test cases. I apologize for my carelessness.
Jul 24 2019
Jul 23 2019
Jul 22 2019
Final review ping.
Ping. I am going to submit this patch if nobody objects.
Jul 16 2019
Jul 15 2019
Jul 13 2019
Jul 12 2019
Fix spelling / comment / naming issues.
Jul 11 2019
Jul 10 2019
- Have a workaround inside top-level CMakeLists.txt to set TARGET_OS to Android.
- Test against TARGET_OS instead of TEST_SUITE_REMOTE_CLIENT in the build system.
- lit.site.cfg.in: remove the double quote around @TEST_SUITE_PROFILE_GENERATE@.
Jul 9 2019
Jun 28 2019
Jun 26 2019
Hey @MaskRay , can you explain why we should remove --print-supported-cpus. There already are similar options in clang such as --print-effective-triple and --print-libgcc-file-name. On the other hand, I almost never see an option goes like -xxx=?. Also, why can't we support both since they are just aliases to each other?
Jun 25 2019
Reviewed at https://reviews.llvm.org/D63105. Forgot to link it. Sorry.
Jun 17 2019
This option is useful but may be hard to discover. Will something like -march=? and -mtune=? make the feature more discoverable?
That's a good idea. Currently, my change has nothing to do with -march or -mtune. I might work on that later.
Jun 14 2019
@dyung I pushed another commit to fix the test. Let me know if the problem persists.
I am working on fixing the test file right now. I will add REQUIRES: x86-registered-target and REQUIRES: arm-registered-target before each test correspondingly.
Committed. SVN Revision: 363464.
Jun 12 2019
Adjust the docs: remove the redundant -mcpu flag. Add an explanation for --print-supported-cpus.
Replace one manual delete with std::unique_ptr.
Use None for an llvm::Optional value.
Add one more test case.
Adjust the message printout to include the usage of -mtune.
Jun 11 2019
Add full context. Change the name of the static variable from "Printed" to "PrintOnce". Add a newline for the test file.