This is an archive of the discontinued LLVM Phabricator instance.

Differential D63768

[ELF] Don't create Undefined for discarded .debug* sections
AbandonedPublic

Authored by MaskRay on Jun 25 2019, 7:06 AM.

Details

Reviewers
hans
• espindola
Summary

A hypothetical work around of
https://bugs.chromium.org/p/chromium/issues/detail?id=978067

Diff Detail

Event Timeline

MaskRay created this revision.Jun 25 2019, 7:06 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJun 25 2019, 7:07 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, arichardson, emaste. · View Herald Transcript
Harbormaster completed remote builds in B33881: Diff 206438.Jun 25 2019, 7:07 AM
MaskRay added a comment.Jun 25 2019, 8:12 AM

This does not work.

I'll change it to a clean revert.

MaskRay abandoned this revision.Jun 25 2019, 8:23 AM

Revision Contents

PathSize
ELF/
3 lines

Diff 206438

ELF/InputFiles.cpp

Show First 20 Lines • Show All 1,074 Lines • ▼ Show 20 Lines if (Binding == STB_LOCAL) {
if (ESym.getType() == STT_FILE) if (ESym.getType() == STT_FILE)
SourceFile = CHECK(ESym.getName(this->StringTable), this); SourceFile = CHECK(ESym.getName(this->StringTable), this);
if (this->StringTable.size() <= ESym.st_name) if (this->StringTable.size() <= ESym.st_name)
fatal(toString(this) + ": invalid symbol name offset"); fatal(toString(this) + ": invalid symbol name offset");
if (ESym.st_shndx == SHN_UNDEF) if (ESym.st_shndx == SHN_UNDEF)
this->Symbols[I] = make<Undefined>(this, Name, Binding, StOther, Type); this->Symbols[I] = make<Undefined>(this, Name, Binding, StOther, Type);
else if (Sec == &InputSection::Discarded) else if (Sec == &InputSection::Discarded &&
!Sec->Name.startswith(".debug"))
this->Symbols[I] = make<Undefined>(this, Name, Binding, StOther, Type, this->Symbols[I] = make<Undefined>(this, Name, Binding, StOther, Type,
/*DiscardedSecIdx=*/SecIdx); /*DiscardedSecIdx=*/SecIdx);
else else
this->Symbols[I] = this->Symbols[I] =
make<Defined>(this, Name, Binding, StOther, Type, Value, Size, Sec); make<Defined>(this, Name, Binding, StOther, Type, Value, Size, Sec);
continue; continue;
} }
▲ Show 20 Lines • Show All 549 Lines • Show Last 20 Lines