[Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc

[ro]

Summary

I noticed that the instance of OpenFile in sanitizer_solaris.cc is no longer needed.

Removed as follows, tested on x86_64-pc-solaris2.11. Ok for trunk?

[ro]

Ping? It's been a week and the patch is as obvious as it gets.

[dvyukov]

Are you sure it's unused? I see several uses of this function:

lib$ grep OpenFile sanitizer_common/*.{h,cc} tsan/rtl/*.cc
sanitizer_common/sanitizer_file.h:fd_t OpenFile(const char *filename, FileAccessMode mode,
sanitizer_common/sanitizer_posix.h:// Don't use directly, use __sanitizer::OpenFile() instead.
sanitizer_common/sanitizer_coverage_libcdep_new.cc:static fd_t OpenFile(const char* path) {
sanitizer_common/sanitizer_coverage_libcdep_new.cc: fd_t fd = OpenFile(path, WrOnly, &err);
sanitizer_common/sanitizer_coverage_libcdep_new.cc: fd_t fd = OpenFile(file_path);
sanitizer_common/sanitizer_file.cc: fd = OpenFile(full_path, WrOnly);
sanitizer_common/sanitizer_file.cc: fd_t fd = OpenFile(file_name, RdOnly, errno_p);
sanitizer_common/sanitizer_file.cc: fd_t fd = OpenFile(file_name, RdOnly, errno_p);
sanitizer_common/sanitizer_linux_libcdep.cc: fd_t fd = OpenFile("/proc/self/statm", RdOnly);
sanitizer_common/sanitizer_posix.cc:fd_t OpenFile(const char *filename, FileAccessMode mode, error_t *errno_p) {
sanitizer_common/sanitizer_posix.cc: fd_t fd = OpenFile(file_name, RdOnly);
sanitizer_common/sanitizer_rtems.cc:fd_t OpenFile(const char *filename, FileAccessMode mode, error_t *errno_p) {
sanitizer_common/sanitizer_solaris.cc:uptr OpenFile(const char *filename, bool write) {
sanitizer_common/sanitizer_win.cc: fd_t fd = OpenFile(modname, RdOnly, nullptr);
sanitizer_common/sanitizer_win.cc:fd_t OpenFile(const char *filename, FileAccessMode mode, error_t *last_error) {
tsan/rtl/tsan_rtl.cc: fd_t fd = OpenFile(filename.data(), WrOnly);

[ro]

In D63764#1566108, @dvyukov wrote:

Are you sure it's unused? I see several uses of this function:

True, but with the instance in sanitizer_solaris.cc removed, the one in sanitizer_posix.cc is used: sanitizer_file.h declares a default for the
last arg.

Both make and make check-all complete successfully without it.

[dvyukov]

Then looks like the right thing to do.
Do you have commit access? Or you want me to submit this?

[ro]

In D63764#1566114, @dvyukov wrote:

Then looks like the right thing to do.
Do you have commit access? Or you want me to submit this?

I do and will commit the patch soon.

Thanks.

Rainer

compiler-rt/trunk/lib/sanitizer_common/sanitizer_solaris.cc

 uptr internal_open(const char *filename, int flags) {
   return _REAL64(open)(filename, flags);
 }
 
 uptr internal_open(const char *filename, int flags, u32 mode) {
   return _REAL64(open)(filename, flags, mode);
 }
 
-uptr OpenFile(const char *filename, bool write) {
-  return ReserveStandardFds(
-      internal_open(filename, write ? O_WRONLY | O_CREAT : O_RDONLY, 0660));
-}
-
 DECLARE__REAL_AND_INTERNAL(uptr, read, fd_t fd, void *buf, uptr count) {
   return _REAL(read)(fd, buf, count);
 }
 
 DECLARE__REAL_AND_INTERNAL(uptr, write, fd_t fd, const void *buf, uptr count) {
   return _REAL(write)(fd, buf, count);
 }