Page MenuHomePhabricator

Remove core loading timeout
ClosedPublic

Authored by labath on Jun 24 2019, 10:56 AM.

Details

Summary

If target.preload-symbols is false, waiting for the process to "stop"
can take an arbitrarily long amount of time, because it will cause all
the debug info to be parsed (to compute the stop message showing the
function, its arguments, etc).

We were previously waiting for 10 seconds for the stop even to arrive,
which is a pretty long time, but it's not that hard to overcome with
huge debug info.

Since any arbitrary limit can be theoretically overcome with huge
debug_info and/or slow machine, and the stop even was sent 3 lines above
the wait, if we ever do not receive the stop even means we've got a bug
in lldb. Therefore, I remove the timeout on this wait completely.

No test because I don't know how to reproduce this without a
multi-gigabyte symbol file.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Jun 24 2019, 10:56 AM
clayborg accepted this revision.Jun 24 2019, 11:05 AM
This revision is now accepted and ready to land.Jun 24 2019, 11:05 AM
Closed by commit rL364276: Remove core loading timeout (authored by labath, committed by ). · Explain WhyJun 25 2019, 12:14 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2019, 12:14 AM