Skip to content

Commit 7ada1c5

Browse files
committedJun 25, 2019
Remove core loading timeout
Summary: If target.preload-symbols is false, waiting for the process to "stop" can take an arbitrarily long amount of time, because it will cause all the debug info to be parsed (to compute the stop message showing the function, its arguments, etc). We were previously waiting for 10 seconds for the stop even to arrive, which is a pretty long time, but it's not that hard to overcome with huge debug info. Since any arbitrary limit can be theoretically overcome with huge debug_info and/or slow machine, and the stop even was sent 3 lines above the wait, if we ever do not receive the stop even means we've got a bug in lldb. Therefore, I remove the timeout on this wait completely. No test because I don't know how to reproduce this without a multi-gigabyte symbol file. Reviewers: jingham, clayborg Subscribers: aprantl, lldb-commits Differential Revision: https://reviews.llvm.org/D63730 llvm-svn: 364276
1 parent 0d45eab commit 7ada1c5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎lldb/source/Target/Process.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -2687,7 +2687,7 @@ Status Process::LoadCore() {
26872687
// Wait for a stopped event since we just posted one above...
26882688
lldb::EventSP event_sp;
26892689
StateType state =
2690-
WaitForProcessToStop(seconds(10), &event_sp, true, listener_sp);
2690+
WaitForProcessToStop(llvm::None, &event_sp, true, listener_sp);
26912691

26922692
if (!StateIsStoppedState(state, false)) {
26932693
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_PROCESS));

0 commit comments

Comments
 (0)