As we currently have it implemented in altivec.h, the offsets for these two intrinsics are element offsets. The documentation in the ABI (as well as the implementation in both XL and GCC) states that these should be byte offsets.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
A few questions.
lib/Headers/altivec.h | ||
---|---|---|
16364 ↗ | (On Diff #205937) | Why we name it Adjusted? Why not just __addr? |
16365 ↗ | (On Diff #205937) | Why we want to cast it to (signed short *) again? Looks like unnecessary casting to me? |
test/CodeGen/builtins-ppc-xl-xst.c | ||
4 ↗ | (On Diff #205937) | Any difference for results without power8-vector , except for test9 and test10? Why not split test9 and test10 to another file for simplicity? |
lib/Headers/altivec.h | ||
---|---|---|
16364 ↗ | (On Diff #205937) | Sure. I don't really have any preference with respect to the name at all. |
16365 ↗ | (On Diff #205937) | Argh, yup the double cast is silly. I initially did something different for this and just missed cleaning up these. I'll update. |
test/CodeGen/builtins-ppc-xl-xst.c | ||
4 ↗ | (On Diff #205937) | I like running all of them both with and without power8-vector. I can simplify this by using check-prefixes=CHECK,CHECK-P8 so that we only have one sequence of checks for each function. |