Page MenuHomePhabricator
People rzurob

rzurob (Rafik Zurob)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 1 2019, 6:28 AM (212 w, 6 d)

Recent Activity
View All

Feb 2 2023

rzurob accepted D140245: [PowerPC] Don't crash when disassembling invalid immediate.

LGTM

Feb 2 2023, 9:06 AM · Restricted Project, Restricted Project

Nov 29 2022

rzurob accepted D138944: [AIX][LTO] Properly respect LDR_CNTRL and set MAXDATA32 to 0xA0000000@DSA.

LGTM.

Nov 29 2022, 1:03 PM · Restricted Project, Restricted Project

Nov 1 2021

rzurob accepted D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning.

LGTM

Nov 1 2021, 10:49 AM · Restricted Project
rzurob requested changes to D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning.

Please change to "IBM XL C/C++ for AIX 16.1.0". i.e. No ", V". Thanks.

Nov 1 2021, 7:24 AM · Restricted Project

Oct 13 2021

rzurob accepted D111433: [PowerPC] Respect rounding mode in the back end.

LGTM

Oct 13 2021, 7:49 AM · Restricted Project

Mar 19 2021

rzurob accepted D98579: [llvm-jitlink] Fix use of getaddrinfo(3) when connecting remote executor via TCP socket.

LGTM

Mar 19 2021, 10:20 AM · Restricted Project
rzurob accepted D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.

LGTM

Mar 19 2021, 9:25 AM · Restricted Project

Mar 15 2021

rzurob added inline comments to D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.
Mar 15 2021, 9:05 PM · Restricted Project

Mar 8 2021

rzurob accepted D98064: [PowerPC] Removing _massv place holder .

LGTM

Mar 8 2021, 11:52 AM · Restricted Project, Restricted Project

Jan 26 2021

rzurob added a comment to D95477: [llvm-jitlink] Replace use of deprecated gethostbyname by getaddrinfo..
In D95477#2523851, @tschuett wrote:

The man page uses:

memset(Hints, 0, sizeof(Hints));

https://man7.org/linux/man-pages/man3/getaddrinfo.3.html

Jan 26 2021, 4:34 PM · Restricted Project
rzurob added inline comments to D95477: [llvm-jitlink] Replace use of deprecated gethostbyname by getaddrinfo..
Jan 26 2021, 1:37 PM · Restricted Project

Aug 20 2020

rzurob added inline comments to D86262: [LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass.
Aug 20 2020, 4:14 AM · Restricted Project

Jul 22 2020

rzurob accepted D84277: [PowerPC][Power10] Fix vins*vlx instructions to have i32 arguments..

LGTM

Jul 22 2020, 1:58 AM · Restricted Project, Restricted Project, Restricted Project
rzurob accepted D84291: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation.

LGTM

Jul 22 2020, 1:18 AM · Restricted Project, Restricted Project, Restricted Project

Jul 14 2020

rzurob accepted D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..

LGTM. Thanks!

Jul 14 2020, 6:01 AM · Restricted Project, Restricted Project, Restricted Project

Jul 9 2020

rzurob requested changes to D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..

We should update vins[bhw][lr] too. They have the same problem.

Jul 9 2020, 9:48 PM · Restricted Project, Restricted Project, Restricted Project