Page MenuHomePhabricator

[binutils] Add response file option to help and docs
ClosedPublic

Authored by jhenderson on Thu, Jun 20, 6:16 AM.

Details

Summary

Many LLVM-based tools already support response files (i.e. files containing a list of options, specified with '@'). This change simply updates the documentation and help text for some of these tools to include it. I haven't attempted to fix all tools, just a selection that I am interested in.

I've taken the opportunity to add some tests for --help behaviour, where they were missing. We could expand these tests, but I don't think that's within scope of this patch.

This fixes https://bugs.llvm.org/show_bug.cgi?id=42233 and https://bugs.llvm.org/show_bug.cgi?id=42236.

Diff Detail

Repository
rL LLVM

Event Timeline

jhenderson created this revision.Thu, Jun 20, 6:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jun 20, 6:16 AM
jhenderson edited the summary of this revision. (Show Details)Thu, Jun 20, 6:17 AM

D63565 needs to land first for the llvm-dwarfdump test to work, due to an odd difference in behaviour between -h and --help in llvm-dwarfdump.

jkorous accepted this revision.Thu, Jun 20, 1:26 PM
jkorous added a subscriber: jkorous.

LGTM

This revision is now accepted and ready to land.Thu, Jun 20, 1:26 PM
MaskRay accepted this revision.Thu, Jun 20, 7:50 PM
grimar accepted this revision.Fri, Jun 21, 1:21 AM

LGTM

This revision was automatically updated to reflect the committed changes.