Page MenuHomePhabricator

[llvm-nm] Generalize symbol types 'N' and 'n'
ClosedPublic

Authored by MaskRay on Wed, Jun 19, 11:57 PM.

Diff Detail

Event Timeline

MaskRay created this revision.Wed, Jun 19, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Jun 19, 11:57 PM
MaskRay updated this revision to Diff 205743.Thu, Jun 20, 12:03 AM

Improve the test

grimar added inline comments.Thu, Jun 20, 12:38 AM
tools/llvm-nm/llvm-nm.cpp
915 ↗(On Diff #205743)

Shouldn't the new code fail with LLVM_ENABLE_ABI_BREAKING_CHECKS because of removing this line?

MaskRay marked an inline comment as done.Thu, Jun 20, 12:50 AM
MaskRay added inline comments.
tools/llvm-nm/llvm-nm.cpp
915 ↗(On Diff #205743)

llvm::object::SectionRef::getName(StringRef) still returns error_code... ( it has 95 references so i didn't fix it to use Error instead)

MaskRay marked an inline comment as done.Thu, Jun 20, 12:51 AM
MaskRay added inline comments.
tools/llvm-nm/llvm-nm.cpp
915 ↗(On Diff #205743)

Oh sorry, it should be Expected<StringRef>. Anyway, I haven't started the refactoring yet..

grimar accepted this revision.Thu, Jun 20, 12:52 AM

LGTM (assuming the output is consistent with GNU nm).

tools/llvm-nm/llvm-nm.cpp
915 ↗(On Diff #205743)

Ah, I see.

This revision is now accepted and ready to land.Thu, Jun 20, 12:52 AM
jhenderson accepted this revision.Thu, Jun 20, 2:38 AM

LGTM too. I'll update the doc patch.

This revision was automatically updated to reflect the committed changes.