This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Undo sub x, c canonicalization for v2i16
ClosedPublic

Authored by arsenm on Jun 19 2019, 8:27 AM.

Details

Summary

Should avoid regression from D62341

Diff Detail

Event Timeline

arsenm created this revision.Jun 19 2019, 8:27 AM
rampitec added inline comments.Jun 19 2019, 2:18 PM
lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
93

Don't you have warnings doing negation on an uint? Making it int may be cleaner.

arsenm marked an inline comment as done.Jun 19 2019, 2:23 PM
arsenm added inline comments.
lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
93

There's no warning because it's the same operation. Making it int would be worse, because then it would involve multiple casts to get the unsigned shift

This revision is now accepted and ready to land.Jun 19 2019, 2:26 PM
arsenm closed this revision.Jun 19 2019, 4:34 PM

r363899