Page MenuHomePhabricator

Wordsmith the semantics of invariant.load
AcceptedPublic

Authored by sanjoy on Jun 17 2019, 9:24 AM.

Details

Reviewers
skatkov
ebrevnov
Summary

Don't phrase the semantics in terms of the optimizer. Instead have a
more straightforward execution based semantic.

Diff Detail

Event Timeline

sanjoy created this revision.Jun 17 2019, 9:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2019, 9:24 AM

I'm ok with this change however I think that "executed" term may be somehow specified more. May be "executed at runtime" ?

I'm ok with this change however I think that "executed" term may be somehow specified more. May be "executed at runtime" ?

Not trying to sound flippant here, but what other ways are there to execute the load?

I'm ok with this change however I think that "executed" term may be somehow specified more. May be "executed at runtime" ?

Not trying to sound flippant here, but what other ways are there to execute the load?

I do not know :)

ebrevnov accepted this revision.Mon, Jul 8, 9:04 PM

LGTM

This revision is now accepted and ready to land.Mon, Jul 8, 9:04 PM