This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Fix RegBankSelect for s1 sext/zext/anyext
ClosedPublic

Authored by arsenm on Jun 17 2019, 4:36 AM.

Details

Summary

This needs different handling if the source is known to be a valid
condition or not. Handle turning it into shifts or a select during
regbankselect.

Diff Detail

Event Timeline

arsenm created this revision.Jun 17 2019, 4:36 AM
arsenm marked an inline comment as done.Jun 24 2019, 6:04 AM

ping

lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
841–842

I'm not sure if this case should really be allowed

tstellar accepted this revision.Jun 24 2019, 6:57 AM

LGTM.

This revision is now accepted and ready to land.Jun 24 2019, 6:57 AM
arsenm closed this revision.Jun 24 2019, 7:54 AM

r364186