This is an archive of the discontinued LLVM Phabricator instance.

Differential D63356

UpdateTestChecks: Consider .section as end of function for AMDGPU
ClosedPublic

Authored by arsenm on Jun 14 2019, 1:03 PM.

Details

Reviewers
RKSimon
kzhuravl
scott.linder
Summary

Kernels seem to go directly to a section switch instead of emitting
.Lfunc_end. This fixes including all of the kernel metadata in the
check lines, which is undesirable most of the time.

Diff Detail

Event Timeline

arsenm created this revision.Jun 14 2019, 1:03 PM
Herald added subscribers: t-tye, tpr, dstuttard and 2 others. · View Herald TranscriptJun 14 2019, 1:03 PM
scott.linder accepted this revision.Jun 14 2019, 1:32 PM
This revision is now accepted and ready to land.Jun 14 2019, 1:32 PM
arsenm closed this revision.Jun 14 2019, 1:37 PM

r363452

Revision Contents

PathSize
utils/
UpdateTestChecks/
2 lines

Diff 204833

utils/UpdateTestChecks/asm.py

Show All 33 LinesASM_FUNCTION_AARCH64_RE = re.compile(
# This list is incomplete # This list is incomplete
r'.Lfunc_end[0-9]+:\n', r'.Lfunc_end[0-9]+:\n',
flags=(re.M | re.S)) flags=(re.M | re.S))
ASM_FUNCTION_AMDGPU_RE = re.compile( ASM_FUNCTION_AMDGPU_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*;+[ \t]*@(?P=func)\n[^:]*?' r'^_?(?P<func>[^:]+):[ \t]*;+[ \t]*@(?P=func)\n[^:]*?'
r'(?P<body>.*?)\n' # (body of the function) r'(?P<body>.*?)\n' # (body of the function)
# This list is incomplete # This list is incomplete
r'.Lfunc_end[0-9]+:\n', r'^\s*(\.Lfunc_end[0-9]+:\n|\.section)',
flags=(re.M | re.S)) flags=(re.M | re.S))
ASM_FUNCTION_HEXAGON_RE = re.compile( ASM_FUNCTION_HEXAGON_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*//[ \t]*@(?P=func)\n[^:]*?' r'^_?(?P<func>[^:]+):[ \t]*//[ \t]*@(?P=func)\n[^:]*?'
r'(?P<body>.*?)\n' # (body of the function) r'(?P<body>.*?)\n' # (body of the function)
# This list is incomplete # This list is incomplete
r'.Lfunc_end[0-9]+:\n', r'.Lfunc_end[0-9]+:\n',
flags=(re.M | re.S)) flags=(re.M | re.S))
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines