[clang-tidy] Fixed abseil-duration-unnecessary-conversion tests for c++17

[jvikstrom]

Summary

Fixed abseil-duration-unnecessary-conversion tests for c++17

clang-tools-extra/trunk/clang-tidy/abseil/DurationUnnecessaryConversionCheck.cpp

for (const auto &Scale : {"Hours", "Minutes", "Seconds", "Milliseconds",
     std::string DurationFactory = (llvm::Twine("::absl::") + Scale).str();
     std::string FloatConversion =
         (llvm::Twine("::absl::ToDouble") + Scale).str();
     std::string IntegerConversion =
         (llvm::Twine("::absl::ToInt64") + Scale).str();
 
     // Matcher which matches the current scale's factory with a `1` argument,
     // e.g. `absl::Seconds(1)`.
-    auto factory_matcher = cxxConstructExpr(hasArgument(
-        0,
+    auto factory_matcher = ignoringElidableConstructorCall(
         callExpr(callee(functionDecl(hasName(DurationFactory))),
-                 hasArgument(0, ignoringImpCasts(integerLiteral(equals(1)))))));
+                 hasArgument(0, ignoringImpCasts(integerLiteral(equals(1))))));
 
     // Matcher which matches either inverse function and binds its argument,
     // e.g. `absl::ToDoubleSeconds(dur)`.
     auto inverse_function_matcher = callExpr(
         callee(functionDecl(hasAnyName(FloatConversion, IntegerConversion))),
         hasArgument(0, expr().bind("arg")));
 
     // Matcher which matches a duration divided by the factory_matcher above,

clang-tools-extra/trunk/test/clang-tidy/abseil-duration-unnecessary-conversion.cpp

-// RUN: %check_clang_tidy -std=c++11,c++14 %s abseil-duration-unnecessary-conversion %t -- -- -I %S/Inputs
-// FIXME: Fix the checker to work in C++17 mode.
+// RUN: %check_clang_tidy -std=c++11-or-later %s abseil-duration-unnecessary-conversion %t -- -- -I %S/Inputs
 
 #include "absl/time/time.h"
 
 void f() {
   absl::Duration d1, d2;
 
   // Floating point
   d2 = absl::Hours(absl::ToDoubleHours(d1));