This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] gfx1010 premlane instructions
ClosedPublic

Authored by rampitec on Jun 12 2019, 7:34 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

rampitec created this revision.Jun 12 2019, 7:34 AM
arsenm added inline comments.Jun 12 2019, 8:10 AM
include/llvm/IR/IntrinsicsAMDGPU.td
1441 ↗(On Diff #204283)

Do these need to be marked as SourceOfDivergence?

1443 ↗(On Diff #204283)

A bunch of these should be immarg

1449 ↗(On Diff #204283)

Ditto

lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
3007 ↗(On Diff #204283)

Missing assembler test

rampitec marked 2 inline comments as done.Jun 12 2019, 8:15 AM
rampitec added inline comments.
include/llvm/IR/IntrinsicsAMDGPU.td
1441 ↗(On Diff #204283)

Probably, but in a separate patch. It has vgpr arguments, so shall be treated as divergent anyway I think.

lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
3007 ↗(On Diff #204283)

It is not missing. There is a huge stack of dependent changes, so tests will follow. They can hardly be separated.

arsenm added inline comments.Jun 12 2019, 8:25 AM
include/llvm/IR/IntrinsicsAMDGPU.td
1441 ↗(On Diff #204283)

DivergenceAnalysis assumes intrinsic calls are uniform with uniform arguments

rampitec marked 5 inline comments as done.
rampitec added inline comments.
include/llvm/IR/IntrinsicsAMDGPU.td
1449 ↗(On Diff #204283)
kzhuravl accepted this revision.Jun 12 2019, 10:44 AM

LGTM, thanks.

This revision is now accepted and ready to land.Jun 12 2019, 10:44 AM
This revision was automatically updated to reflect the committed changes.
rampitec marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2019, 10:51 AM