Page MenuHomePhabricator

[clangd] Implement "prepareRename"
Needs ReviewPublic

Authored by hokein on Jun 11 2019, 2:30 AM.

Details

Reviewers
sammccall
Summary

"prepareRename" request is added in LSP v3.12.0.

No test yet, but want some early feedback.

Unfortunately, due to the bug in VSCode LSP[1], the rename dialog still
shows up when we return null in prepareRename. The fix is not released
in the latest version.

[1]: https://github.com/microsoft/vscode-languageserver-node/issues/447

Event Timeline

hokein created this revision.Jun 11 2019, 2:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2019, 2:30 AM