This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Fix name_to_handle_at.cc test on Overlay2
ClosedPublic

Authored by amyk on Jun 10 2019, 1:41 PM.

Details

Summary

This patch aims to fix the test case, name_to_handle_at.cc that fails on Docker.

Overlay2 on Docker does not support the current check for the `name_to_handle_at() function call`of the test case.
Thus, the proposed fix is to check for /dev/null in the test instead, as this check is supported.
Checking for /dev/null has been utilized in the past for other test cases, as well.

Diff Detail

Event Timeline

amyk created this revision.Jun 10 2019, 1:41 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 10 2019, 1:41 PM
Herald added subscribers: llvm-commits, Restricted Project, jsji and 2 others. · View Herald Transcript
eugenis accepted this revision.Jun 10 2019, 2:50 PM

LGTM

This revision is now accepted and ready to land.Jun 10 2019, 2:50 PM
ormris removed a subscriber: ormris.Jun 10 2019, 2:58 PM
This revision was automatically updated to reflect the committed changes.