This is an archive of the discontinued LLVM Phabricator instance.

Differential D62924

[cmake] Remove duplicate TestingSupport library for linking
ClosedPublic

Authored by pzheng on Jun 5 2019, 11:56 AM.

Details

Reviewers
quantum
thakis
tlively
Commits
rGe34d1a4e07b8: [cmake] Remove duplicate TestingSupport library for linking
rL362637: [cmake] Remove duplicate TestingSupport library for linking
rC362637: [cmake] Remove duplicate TestingSupport library for linking
Summary

This patch cleans up a duplicate use of TestingSupport library.

Diff Detail

Event Timeline

pzheng created this revision.Jun 5 2019, 11:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2019, 11:56 AM
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B32952: Diff 203217.Jun 5 2019, 11:56 AM
pzheng added reviewers: quantum, thakis, tlively.Jun 5 2019, 11:58 AM
quantum accepted this revision.Jun 5 2019, 12:35 PM
This revision is now accepted and ready to land.Jun 5 2019, 12:35 PM
Closed by commit rGe34d1a4e07b8: [cmake] Remove duplicate TestingSupport library for linking (authored by pzheng). · Explain WhyJun 5 2019, 12:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
unittests/
Tooling/
1 line

Diff 203229

clang/unittests/Tooling/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
Support Support
TestingSupport
) )
# By default MSVC has a 2^16 limit on the number of sections in an object file, # By default MSVC has a 2^16 limit on the number of sections in an object file,
# and this needs more than that. # and this needs more than that.
if (MSVC) if (MSVC)
set_source_files_properties(RecursiveASTVisitorTest.cpp PROPERTIES COMPILE_FLAGS /bigobj) set_source_files_properties(RecursiveASTVisitorTest.cpp PROPERTIES COMPILE_FLAGS /bigobj)
set_source_files_properties(RecursiveASTVisitorTestExprVisitor.cpp PROPERTIES COMPILE_FLAGS /bigobj) set_source_files_properties(RecursiveASTVisitorTestExprVisitor.cpp PROPERTIES COMPILE_FLAGS /bigobj)
endif() endif()
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines