Page MenuHomePhabricator

Read .note.gnu.property sections and emit a merged .note.gnu.property section.
ClosedPublic

Authored by ruiu on Jun 4 2019, 4:56 AM.

Details

Summary

This patch also adds --requires-cet option for the sake of testing.
The actual feature for IBT-aware PLT is not included in this patch.

This is a part of https://reviews.llvm.org/D59780. Submitting this
first should make it easy to work with a related change
(https://reviews.llvm.org/D62609).

Diff Detail

Repository
rL LLVM

Event Timeline

ruiu created this revision.Jun 4 2019, 4:56 AM
Herald added a project: Restricted Project. · View Herald Transcript
peter.smith accepted this revision.Jun 4 2019, 9:04 AM

Thanks very much for extracting the .note.gnu.property parsing code. There was one modification I'd made in D62609 that permitted multiple GNU_PROPERTY_X86_FEATURE_1_AND properties in the same .note.gnu.property section as this was observed in the ld.bfd testsuite. I'll submit a patch with just these modifications in.

One thing to mention here is that we may want to give a warning that IBT support is not implemented yet as this could result in a output that would fault (claims support via GNU_PROPERTY_X86_FEATURE_1_IBT) should anyone try to use it.

This revision is now accepted and ready to land.Jun 4 2019, 9:04 AM

Thanks very much for extracting the .note.gnu.property parsing code. There was one modification I'd made in D62609 that permitted multiple GNU_PROPERTY_X86_FEATURE_1_AND properties in the same .note.gnu.property section as this was observed in the ld.bfd testsuite. I'll submit a patch with just these modifications in.

I've created D62862 which is independent of X86/AArch64.

emaste added a comment.Jun 4 2019, 9:40 AM

I've created D62862 which is independent of X86/AArch64.

D62862 is x86-specific right now?

I've created D62862 which is independent of X86/AArch64.

D62862 is x86-specific right now?

Apologies I should have been clearer. The change in D62862 just permits more than one GNU_PROPERTY_X86_FEATURE_1_AND to be read which is actually X86 specific. I'm rebasing D62609 on top of this and D62862 which will add AArch64 support.

MaskRay accepted this revision.Jun 4 2019, 7:18 PM

This patch also adds --requires-cet option for the sake of testing.

Typo, --require-cet?

This revision was automatically updated to reflect the committed changes.