This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Print the ignored variant symbols
Needs ReviewPublic

Authored by hokein on Jun 3 2019, 5:29 AM.

Details

Reviewers
sammccall
Summary

so that we can better track those symbols.

Event Timeline

hokein created this revision.Jun 3 2019, 5:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2019, 5:29 AM
sammccall added inline comments.Jun 6 2019, 1:25 PM
clang-tools-extra/clangd/include-mapping/gen_std.py
119

this is a significantly more complicated signature - do we need the extra precision in the log message vs e.g. Ignored variant of symbol abs from path/to/complex.html?

hokein marked an inline comment as done.Jun 7 2019, 3:10 AM
hokein added inline comments.
clang-tools-extra/clangd/include-mapping/gen_std.py
119

I think the current information is sufficient (Ignore variant of symbol abs(complex)), we are more caring about the entry name symbol_name (caption) (it is easy for us to find it in the symbol index page).