This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Set PROT_READ flag for MF_EXEC to prevent segfaults on PPC machines
ClosedPublic

Authored by nemanjai on May 31 2019, 9:53 AM.

Details

Summary

The big endian PPC buildbots are all failing now due to calls to cache invalidation in unit tests on data that has only the PROT_EXEC flag set. This has been an issue all along on FreeBSD but it can affect Linux machines depending on configuration.

This patch mitigates the issue the same way it is mitigated on FreeBSD.

Since this is needed to bring the buildbots back to green, I plan to commit this and allow for post-commit review, but I thought I would also post it here for ease of access/readability. My plan is to commit this later this afternoon to unblock the bots.

Diff Detail

Repository
rL LLVM

Event Timeline

nemanjai created this revision.May 31 2019, 9:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2019, 9:53 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2019, 9:18 AM
This revision was automatically updated to reflect the committed changes.