[Index] Correctly set symbol kind of IndirectFieldDecl

[ilya-biryukov]

Summary

The kind has been 'unknown' before, now it is 'field'.

[kadircet]

LGTM thanks!

Do you think it would be beneficial to add some logging for the default case of that switch statement ?

[ilya-biryukov]

In D62573#1520641, @kadircet wrote:

Do you think it would be beneficial to add some logging for the default case of that switch statement ?

We should replace default with all cases it covers to make sure we get a warning when adding a new kind.
But I'm not sure it's going to be a big improvement, maybe it would be even nicer to replace this with some macro magic involving #include "DeclKinds.inc".

clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

EXPECT_THAT(Results.Completions,
                     Has("MACRO", CompletionItemKind::Text),
                     Has("indexFunction", CompletionItemKind::Function),
                     Has("indexVariable", CompletionItemKind::Variable),
                     Has("indexClass", CompletionItemKind::Class)));
 
   Results = completions("nam^");
   EXPECT_THAT(Results.Completions,
               Has("namespace", CompletionItemKind::Snippet));
+
+  // Members of anonymous unions are of kind 'field'.
+  Results = completions(
+      R"cpp(
+        struct X{
+            union {
+              void *a;
+            };
+        };
+        auto u = X().^
+      )cpp");
+  EXPECT_THAT(
+      Results.Completions,
+      UnorderedElementsAre(AllOf(Named("a"), Kind(CompletionItemKind::Field))));
 }
 
 TEST(CompletionTest, NoDuplicates) {
   auto Results = completions(
       R"cpp(
           class Adapter {
           };
 

clang/lib/Index/IndexSymbol.cpp

case Decl::Import:
       Info.Kind = SymbolKind::Module;
       break;
     case Decl::Typedef:
       Info.Kind = SymbolKind::TypeAlias; break; // Lang = C
     case Decl::Function:
       Info.Kind = SymbolKind::Function;
       break;
     case Decl::Field:
+    case Decl::IndirectField:
       Info.Kind = SymbolKind::Field;
       if (const CXXRecordDecl *
             CXXRec = dyn_cast<CXXRecordDecl>(D->getDeclContext())) {
         if (!CXXRec->isCLike())
           Info.Lang = SymbolLanguage::CXX;
       }
       break;
     case Decl::EnumConstant:

clang/test/Index/index-anonymous-union-fields.cpp

+struct X {
+  union {
+    void *a;
+  };
+};
+
+// RUN: c-index-test -index-file %s > %t
+// RUN: FileCheck %s -input-file=%t
+
+// CHECK: [indexDeclaration]: kind: field | name: a | {{.*}} | loc: 3:11