This is an archive of the discontinued LLVM Phabricator instance.

Differential D62474

[CMake] Remove lldb-server from LLDB.framework
ClosedPublic

Authored by sgraenitz on May 26 2019, 11:52 PM.

Details

Reviewers
JDevlieghere
jasonmolenda
xiaobai
Commits
rG72e05d0aa4ff: [CMake] Remove lldb-server from LLDB.framework
rL361947: [CMake] Remove lldb-server from LLDB.framework
rLLDB361947: [CMake] Remove lldb-server from LLDB.framework
Summary

The LLDB test suite doesn't need lldb-server in the framework bundle anymore.

Diff Detail

Event Timeline

sgraenitz created this revision.May 26 2019, 11:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2019, 11:52 PM
Herald added a subscriber: mgorny. · View Herald Transcript
Harbormaster completed remote builds in B32512: Diff 201480.May 26 2019, 11:52 PM
JDevlieghere accepted this revision.May 28 2019, 10:45 AM
This revision is now accepted and ready to land.May 28 2019, 10:45 AM
sgraenitz mentioned this in D62472: [CMake] LLDB.framework tools handling.May 28 2019, 11:16 AM
Closed by commit rLLDB361947: [CMake] Remove lldb-server from LLDB.framework (authored by stefan.graenitz). · Explain WhyMay 29 2019, 4:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
tools/
lldb-server/
4 lines

Diff 201480

lldb/tools/lldb-server/CMakeLists.txt

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines LINK_LIBS
lldbPluginInstructionMIPS64 lldbPluginInstructionMIPS64
${LLDB_SYSTEM_LIBS} ${LLDB_SYSTEM_LIBS}
LINK_COMPONENTS LINK_COMPONENTS
Support Support
) )
target_link_libraries(lldb-server PRIVATE ${LLDB_SYSTEM_LIBS}) target_link_libraries(lldb-server PRIVATE ${LLDB_SYSTEM_LIBS})
if(LLDB_BUILD_FRAMEWORK)
lldb_add_to_framework(lldb-server)
endif()