This is an archive of the discontinued LLVM Phabricator instance.

Fix LLVM_LINK_LLVM_DYLIB build after rC361285
AbandonedPublic

Authored by sbc100 on May 23 2019, 7:58 AM.

Reviewers

ymandel
thakis

Summary

All the other unittests I can find specify LLVMTestingSupport in
target_link_libraries not as part of LLVM_LINK_COMPONENTS.

I'm not sure how/why this fixes the build issue, but its consistent
with other uses.

Repository

rG LLVM Github Monorepo

Build Status

Buildable 32389
Build 32388: arc lint + arc unit

sbc100 edited the summary of this revision. (Show Details)

Thanks for fixing this. Might want to wait for Nico's response, though, since the original change was at his suggestion.

This revision is now accepted and ready to land.May 23 2019, 8:03 AM

Path

Size

clang/

unittests/

Tooling/

2 lines

set(LLVM_LINK_COMPONENTS		set(LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD}		${LLVM_TARGETS_TO_BUILD}
Support		Support
TestingSupport
)		)

# By default MSVC has a 2^16 limit on the number of sections in an object file,		# By default MSVC has a 2^16 limit on the number of sections in an object file,
# and this needs more than that.		# and this needs more than that.
if (MSVC)		if (MSVC)
set_source_files_properties(RecursiveASTVisitorTest.cpp PROPERTIES COMPILE_FLAGS /bigobj)		set_source_files_properties(RecursiveASTVisitorTest.cpp PROPERTIES COMPILE_FLAGS /bigobj)
set_source_files_properties(RecursiveASTVisitorTestExprVisitor.cpp PROPERTIES COMPILE_FLAGS /bigobj)		set_source_files_properties(RecursiveASTVisitorTestExprVisitor.cpp PROPERTIES COMPILE_FLAGS /bigobj)
endif()		endif()
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines	target_link_libraries(ToolingTests
clangFrontend		clangFrontend
clangLex		clangLex
clangRewrite		clangRewrite
clangSerialization		clangSerialization
clangTooling		clangTooling
clangToolingCore		clangToolingCore
clangToolingInclusions		clangToolingInclusions
clangToolingRefactor		clangToolingRefactor
		LLVMTestingSupport
)		)


add_subdirectory(Syntax)		add_subdirectory(Syntax)