Page MenuHomePhabricator

Expression: correct relocation model for Windows
ClosedPublic

Authored by compnerd on May 22 2019, 4:04 PM.

Details

Summary

The Windows CG model cannot generate code with the PIC relocation model as all code is implicitly PIC. Invert the condition and inline the single use. This improves expression handling on Windows.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

compnerd created this revision.May 22 2019, 4:04 PM
Herald added a project: Restricted Project. ยท View Herald TranscriptMay 22 2019, 4:04 PM
JDevlieghere accepted this revision.May 22 2019, 4:07 PM

I don't know much about this, but the change seems reasonable.

This revision is now accepted and ready to land.May 22 2019, 4:07 PM
compnerd closed this revision.May 22 2019, 4:23 PM

SVN r361443