Page MenuHomePhabricator

[clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.
ClosedPublic

Authored by sammccall on Mon, May 20, 4:20 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sammccall created this revision.Mon, May 20, 4:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, May 20, 4:20 AM
sammccall updated this revision to Diff 200249.Mon, May 20, 4:25 AM

code-completion-parse -> completion-parse

kadircet accepted this revision.Mon, May 20, 5:15 AM
kadircet added inline comments.
clangd/CodeComplete.h
128 ↗(On Diff #200249)

Do we really have any real use case for this option apart from testing ?

clangd/tool/ClangdMain.cpp
268 ↗(On Diff #200249)

Maybe CodeCompletionOptions().RunParser to keep the defaults at one place

This revision is now accepted and ready to land.Mon, May 20, 5:15 AM
sammccall updated this revision to Diff 200438.Tue, May 21, 2:41 AM
sammccall marked an inline comment as done.

deduplicate default

sammccall marked an inline comment as done.Tue, May 21, 2:41 AM
sammccall added inline comments.
clangd/CodeComplete.h
128 ↗(On Diff #200249)

I don't think so. (If testing includes manual testing/quality tuning, rather than just automated tests)

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptTue, May 21, 6:38 AM