[Bugpoint] fix another use-after-move. NFC

[nickdesaulniers]

Summary

This was flagged in https://www.viva64.com/en/b/0629/ under "Snippet No.
7".

These statements are order independent, short of the use-after-move.

[RKSimon]

LGTM

[dblaikie]

Is this code tested? (what happens if you replace this code with "assert(false);" and then run make check?) If not, it'd be good to add some test coverage that this has revealed is missing.

[nickdesaulniers]

Is this code tested?

Doesn't look like it is. I guess I would have expected a bugpoint directory under llvm/test/tools/.

If not, it'd be good to add some test coverage that this has revealed is missing.

I agree. Filed: https://bugs.llvm.org/show_bug.cgi?id=41970

[nickdesaulniers]

Correction: -DLLVM_BUILD_LLVM_DYLIB="ON" is required to run ninja check-llvm-bugpoint.

It doesn't look like any existing tests under llvm/tests/BugPoint/ call this method at all.

llvm/trunk/tools/bugpoint/Miscompilation.cpp

static Expected<bool> TestOptimizer(BugDriver &BD, std::unique_ptr<Module> Test,
   // Run the optimization passes on ToOptimize, producing a transformed version
   // of the functions being tested.
   outs() << "  Optimizing functions being tested: ";
   std::unique_ptr<Module> Optimized =
       BD.runPassesOn(Test.get(), BD.getPassesToRun());
   if (!Optimized) {
     errs() << " Error running this sequence of passes"
            << " on the input program!\n";
-    BD.setNewProgram(std::move(Test));
     BD.EmitProgressBitcode(*Test, "pass-error", false);
+    BD.setNewProgram(std::move(Test));
     if (Error E = BD.debugOptimizerCrash())
       return std::move(E);
     return false;
   }
   outs() << "done.\n";
 
   outs() << "  Checking to see if the merged program executes correctly: ";
   bool Broken;