This is an archive of the discontinued LLVM Phabricator instance.

Differential D61910

Support FNeg in SpeculativeExecution pass
ClosedPublic

Authored by cameron.mcinally on May 14 2019, 9:02 AM.

Details

Reviewers
spatel
arsenm
kpn
craig.topper
andrew.w.kaylor
Commits
rZORGc2ad40e75e79: Support FNeg in SpeculativeExecution pass
rZORG66bbd3c82110: Support FNeg in SpeculativeExecution pass
rGc2ad40e75e79: Support FNeg in SpeculativeExecution pass
rG66bbd3c82110: Support FNeg in SpeculativeExecution pass
rG7c5c0c9fe59b: Support FNeg in SpeculativeExecution pass
rL360692: Support FNeg in SpeculativeExecution pass

Diff Detail

Repository
rL LLVM

Event Timeline

cameron.mcinally created this revision.May 14 2019, 9:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2019, 9:02 AM
Herald added subscribers: llvm-commits, hiraditya, wdng. · View Herald Transcript
arsenm accepted this revision.May 14 2019, 9:14 AM

LGTM

This revision is now accepted and ready to land.May 14 2019, 9:14 AM
Closed by commit rL360692: Support FNeg in SpeculativeExecution pass (authored by mcinally). · Explain WhyMay 14 2019, 9:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Transforms/
Scalar/
1 line
test/
Transforms/
SpeculativeExecution/
18 lines

Diff 199474

llvm/trunk/lib/Transforms/Scalar/SpeculativeExecution.cpp

Show First 20 Lines • Show All 234 Lines • ▼ Show 20 Lines switch (Operator::getOpcode(I)) {
case Instruction::SIToFP: case Instruction::SIToFP:
case Instruction::FPExt: case Instruction::FPExt:
case Instruction::FPTrunc: case Instruction::FPTrunc:
case Instruction::FAdd: case Instruction::FAdd:
case Instruction::FSub: case Instruction::FSub:
case Instruction::FMul: case Instruction::FMul:
case Instruction::FDiv: case Instruction::FDiv:
case Instruction::FRem: case Instruction::FRem:
case Instruction::FNeg:
case Instruction::ICmp: case Instruction::ICmp:
case Instruction::FCmp: case Instruction::FCmp:
return TTI.getUserCost(I); return TTI.getUserCost(I);
default: default:
return UINT_MAX; // Disallow anything not whitelisted. return UINT_MAX; // Disallow anything not whitelisted.
} }
} }
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines

llvm/trunk/test/Transforms/SpeculativeExecution/spec-fp.ll

Show All 24 Lines
a: a:
%x = fsub float undef, undef %x = fsub float undef, undef
br label %b br label %b
b: b:
ret void ret void
} }
; CHECK-LABEL: @ifThen_fneg( ; CHECK-LABEL: @ifThen_binary_fneg(
; CHECK: fsub float -0.0 ; CHECK: fsub float -0.0
; CHECK: br i1 true ; CHECK: br i1 true
define void @ifThen_fneg() { define void @ifThen_binary_fneg() {
br i1 true, label %a, label %b br i1 true, label %a, label %b
a: a:
%x = fsub float -0.0, undef %x = fsub float -0.0, undef
br label %b br label %b
b: b:
ret void ret void
} }
; CHECK-LABEL: @ifThen_unary_fneg(
; CHECK: fneg float
; CHECK: br i1 true
define void @ifThen_unary_fneg() {
br i1 true, label %a, label %b
a:
%x = fneg float undef
br label %b
b:
ret void
}
; CHECK-LABEL: @ifThen_fmul( ; CHECK-LABEL: @ifThen_fmul(
; CHECK: fmul ; CHECK: fmul
; CHECK: br i1 true ; CHECK: br i1 true
define void @ifThen_fmul() { define void @ifThen_fmul() {
br i1 true, label %a, label %b br i1 true, label %a, label %b
a: a:
%x = fmul float undef, undef %x = fmul float undef, undef
Show All 33 Lines