Change example of input text from being llvm block to being gas block
since that text is made-up assembly.
Details
- Reviewers
jhenderson jdenny probinson arichardson - Commits
- rZORGab91edf497b9: [FileCheck] Fix sphinx error: Make input be gas block
rZORGc2d767bd2690: [FileCheck] Fix sphinx error: Make input be gas block
rGab91edf497b9: [FileCheck] Fix sphinx error: Make input be gas block
rGc2d767bd2690: [FileCheck] Fix sphinx error: Make input be gas block
rG5c15dbafb9da: [FileCheck] Fix sphinx error: Make input be gas block
rL360781: [FileCheck] Fix sphinx error: Make input be gas block
Diff Detail
- Repository
- rL LLVM
Event Timeline
I'm not sure I follow what this achieves. https://llvm.org/docs/CommandGuide/FileCheck.html looks okay to me.... I see the build bot failure. Can you point at documentation that indicates what the problem is?
The only documentation I can find is [1] and [2]. where the former mention that code-block:: llvm is for LLVM IR and the latter specifies that it is for syntax highlighting. The error message seems to corroborate that there is some sort of parsing of the block going on and the two block I'm chanking here are not LLVM IR but made up assembly. I am not able to reproduce the bug sadly (I did manage to reproduce the other one eventually FYI) so cannot get 100% sure it will fix the issue but [2] does mention that code-block:: test is a null parser that does not provide any syntax highlighting.
[1] llvm/docs/SphinxQuickstartTemplate.rst
[2] http://pygments.org/docs/lexers/
llvm/docs/CommandGuide/FileCheck.rst | ||
---|---|---|
596 ↗ | (On Diff #199419) | Could you use gas/asm? |
llvm/docs/CommandGuide/FileCheck.rst | ||
---|---|---|
596 ↗ | (On Diff #199419) | I suppose since there isn't any directive but I wouldn't be able to check that it will build successfully. |
LGTM. If gas doesn't work, feel free to change to text with no further review.
llvm/docs/CommandGuide/FileCheck.rst | ||
---|---|---|
596 ↗ | (On Diff #199419) | Since this is generic assembly, my reading of http://pygments.org/docs/lexers/#pygments.lexers.asm.GasLexer is that this would be the best match, but I don't really know. It's easy enough to fix if that doesn't work though. |