Page MenuHomePhabricator

[IRMover] Improve diagnostic messages for conflicting metadata
ClosedPublic

Authored by ikudrin on May 13 2019, 10:14 PM.

Details

Summary

This does the similar for error messages as D52952 has done for warnings.

With llvm::lto::LTO, the error might appear when LTO::run() is executed. In that case, the calling code cannot know which module causes the error and, subsequently, cannot hint the user.

Diff Detail

Repository
rL LLVM

Event Timeline

ikudrin created this revision.May 13 2019, 10:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2019, 10:14 PM
dblaikie accepted this revision.May 14 2019, 11:36 AM

Seems reasonable - thanks!

This revision is now accepted and ready to land.May 14 2019, 11:36 AM
This revision was automatically updated to reflect the committed changes.