Module IDs can appear in diagnostic messages.
This patch adds some auxiliary symbols to improve their readability.
Details
Details
- Reviewers
ruiu davide grimar • espindola - Commits
- rZORGf28794895dcd: [LTO] Improve readability of module IDs
rGf28794895dcd: [LTO] Improve readability of module IDs
rG4669cf27508b: [LTO] Improve readability of module IDs
rL360858: [LTO] Improve readability of module IDs
rLLD360858: [LTO] Improve readability of module IDs
Diff Detail
Diff Detail
- Repository
- rLLD LLVM Linker
Event Timeline
Comment Actions
My minor concern is that the new message is a bit inconsistent with our other error messages I think.
For example, we have:
{{.*}}.a({{.*}}.o): corrupted ELF file: invalid data encoding
i.e. it is <archive name>(<object name>)
and in your message you have different format:
<archive name>:<offset>(<object name>)
So I would suggest to make it <archive name>(<object name> at <offset>) or <archive name>(<object name>:<offset>) probably.
I think Rui might have a opinion here about how the error message should look like.
Comment Actions
I think I agree with George. Looks like <archive name>(<object name> at <offset>) is slightly more readable than <archive name>(<object name>:<offset>), but that's not a strong preference.
Comment Actions
- Changed the format to <archive name>(<object name> at <offset>);
- Changed "if" to "?:";
- Simplified a check in the tests.