Page MenuHomePhabricator

[clang-format] Fix a JavaScript import order bug.
AcceptedPublic

Authored by bowenni on May 7 2019, 6:48 PM.

Details

Reviewers
djasper
Summary

When the imported symbol is exactly "template" the sorting is disabled.
"import {template} from x;" is not recognized as an import.

Diff Detail

Repository
rC Clang

Event Timeline

bowenni created this revision.May 7 2019, 6:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2019, 6:48 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
bowenni retitled this revision from Fix a JavaScript import order bug. to [clang-format] Fix a JavaScript import order bug..May 7 2019, 6:49 PM
bowenni edited the summary of this revision. (Show Details)May 8 2019, 11:10 AM
bowenni added a reviewer: djasper.
djasper accepted this revision.May 12 2019, 10:46 PM

Generally, upload patches with the full file as context (that will prevent Phabricator's "Context not available")
But this change looks good. Thank you.

This revision is now accepted and ready to land.May 12 2019, 10:46 PM