This fix adds out of scope member classes definitions support for AST Printer.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LGTM except for nits in the tests. I'm not close to C++ support in Clang, so please give other reviewers a few days to comment just in case. I've added a couple who have reviewed my patches in this area in the past.
Thanks for the fix!
clang/test/AST/ast-print-record-decl.c | ||
---|---|---|
291–309 | This comment should stay next to DeclGroupInMemberList because they're both about tag decl groups in member lists. | |
303 | To make this easier to read (especially in editors without highlighting), I suggest putting all FileCheck directives for the definition of each of struct DeclEnclosing and struct DeclEnclosing::DeclMember before that definition. |
clang/lib/AST/DeclPrinter.cpp | ||
---|---|---|
958 | Don't use auto here as the type is not explicitly spelled out in the initialization. If possible, const-qualify the pointer type as well. |