Page MenuHomePhabricator

dyatkovskiy (Stepan Dyatkovskiy)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 2 2014, 12:34 AM (271 w, 4 d)

Recent Activity

May 9 2019

dyatkovskiy updated the diff for D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions.

Patch updates per review remarks

May 9 2019, 1:06 AM · Restricted Project

May 6 2019

dyatkovskiy added a comment to D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions.

@jdenny ? @sepavloff ?
ping

May 6 2019, 4:54 AM · Restricted Project

May 5 2019

dyatkovskiy added reviewers for D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions: sepavloff, jdenny.
May 5 2019, 6:49 AM · Restricted Project
dyatkovskiy created D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions.
May 5 2019, 6:42 AM · Restricted Project

Feb 9 2015

dyatkovskiy added a comment to D7170: MergeFuncs should handle dynamic GEPs.

Hi Pete, I'll go on vocation from next week. And will offline till 10th of March. If you have some diffs to show, please don't hesitate for too long ;-)

Feb 9 2015, 6:01 AM

Feb 2 2015

dyatkovskiy added a comment to D7170: MergeFuncs should handle dynamic GEPs.

Hello Pete,
I've looked at this patch. You add support for dynamic GEPs. I was on non-llvm project for a while, and dynamic GEP is quite new thing, at least when you can use arrays as indices. It also a bit strange, that we can use only splat arrays.. Anyways, I suppose we should get vector of pointers in this case, right? Can you provide me with links, where I can read more about?

Feb 2 2015, 6:40 AM

Jan 28 2015

dyatkovskiy added a comment to D7170: MergeFuncs should handle dynamic GEPs.

Hi Pete,
Thanks for patch. The idea looks good, but I'm still in middle of review..

Jan 28 2015, 6:02 AM

Dec 11 2014

dyatkovskiy committed rL223931: Added documentation for MergeFunctions pass:.
Added documentation for MergeFunctions pass:
Dec 11 2014, 6:37 AM

Jul 25 2014

dyatkovskiy added a comment to D3507: Darwin vararg parameters support in assembler macros.
Jul 25 2014, 12:49 AM
dyatkovskiy added a reviewer for D3507: Darwin vararg parameters support in assembler macros: t.p.northover.

Hi Janne,
What exactly you'd like to merge? Did mean to use GNU style (non-Darwin) everywhere?

Jul 25 2014, 12:48 AM

Jul 15 2014

dyatkovskiy closed D4246: MergeFunc: Don't merge functions with different range metadata on call/invoke.

Committed as r213060
Thanks for working on it!

Jul 15 2014, 11:59 AM

Jul 9 2014

dyatkovskiy added a comment to D4246: MergeFunc: Don't merge functions with different range metadata on call/invoke.

ping
Stepan Dyatkovskiy wrote:

Hi Nick,
can I commit patch for Björn?
Thanks!
-Stepan

Stepan Dyatkovskiy wrote:

LGTM

http://reviews.llvm.org/D4246

Jul 9 2014, 12:52 PM

Jun 27 2014

dyatkovskiy added a comment to D4246: MergeFunc: Don't merge functions with different range metadata on call/invoke.

Hi Nick,
can I commit patch for Björn?
Thanks!
-Stepan

Jun 27 2014, 5:24 PM

Jun 26 2014

dyatkovskiy added a comment to D4254: Fix for PR20104. Enable GAS compliant coprocessor register name..

Andrey,
do you need us to commit it?

Jun 26 2014, 6:03 AM

Jun 25 2014

dyatkovskiy added a reviewer for D4246: MergeFunc: Don't merge functions with different range metadata on call/invoke: nicholas.

LGTM,
now let's wait Nick and talk to him :-)

Jun 25 2014, 11:39 PM
dyatkovskiy added a comment to D4246: MergeFunc: Don't merge functions with different range metadata on call/invoke.

Changes in MergeFunctions.cpp - LGTM
call-with-ranges.ll - LGTM
invoke-with-ranges.ll - read inline comment, otherwise - fine.

Jun 25 2014, 11:34 PM
dyatkovskiy added a comment to D4254: Fix for PR20104. Enable GAS compliant coprocessor register name..

Yup, Renato proposed good idea. Final patch looks fine, except tiny thing, could you use single drop_front call (see inline comments)?

Jun 25 2014, 10:38 PM

Jun 23 2014

dyatkovskiy added a comment to D4246: MergeFunc: Don't merge functions with different range metadata on call/invoke.

Hi Björn,

Jun 23 2014, 7:07 PM
dyatkovskiy updated subscribers of D4254: Fix for PR20104. Enable GAS compliant coprocessor register name..

Hi Andrey,
Thanks for working on it!
I think we have to keep compatibility with GAS.. So in general patch looks reasonable. May be it would be good to add some details what method does (see inline comments).
I've CCed Renato and Tim for approval.

Jun 23 2014, 4:16 PM

Jun 20 2014

dyatkovskiy closed D4062: MergeFunc: Avoid invalid merge of functions using different range metadata.

Committed as r211391.
Thanks!

Jun 20 2014, 2:05 PM

Jun 13 2014

dyatkovskiy added a comment to D4062: MergeFunc: Avoid invalid merge of functions using different range metadata.

Hi Nick,
Can I commit it for Björn?
Thanks!
-Stepan

Jun 13 2014, 6:36 PM

Jun 12 2014

dyatkovskiy added a comment to D4062: MergeFunc: Avoid invalid merge of functions using different range metadata.

Hi Bjorn,
Do you need us to commit your patch? I could do it, if Nick won't object.

Jun 12 2014, 4:13 PM

Jun 11 2014

dyatkovskiy accepted D4062: MergeFunc: Avoid invalid merge of functions using different range metadata.

LGTM! Thanks!

Jun 11 2014, 11:12 AM
dyatkovskiy added a comment to D4062: MergeFunc: Avoid invalid merge of functions using different range metadata.

Yes. Exactly ) For now, I propose to come back to initial patch; make sure tests has been fixed as I asked you in inline comments and, I think we apply it (Nick didn't object about it yesterday).
Then, after we replace ComparableFunction with new structure, you could introduce 'range' metadata merging.
Thanks for working on it!

Jun 11 2014, 10:24 AM

Jun 10 2014

dyatkovskiy added a comment to D4062: MergeFunc: Avoid invalid merge of functions using different range metadata.

Hi Bjorn (sorry I don't have o-umlaut on my keyboard :-) ),

Jun 10 2014, 2:42 PM

Jun 9 2014

dyatkovskiy closed D3437: Fix a mergefunc crash caused by bitcasting intrinsics.

This test has been committed with some changes as r210486. Thanks!

Jun 9 2014, 5:23 PM
dyatkovskiy added a comment to D4062: MergeFunc: Avoid invalid merge of functions using different range metadata.

Hi Bjorn,
You have found really interesting point :-)
For this changes set, please, read inline comments.

Jun 9 2014, 3:05 PM

Jun 5 2014

dyatkovskiy added a comment to D3437: Fix a mergefunc crash caused by bitcasting intrinsics.

OK. I'll try to commit it for you in nearest days. All I need is meet Nick in IRC and ask about this test.

Jun 5 2014, 3:10 PM
dyatkovskiy added a comment to D3437: Fix a mergefunc crash caused by bitcasting intrinsics.
Jun 5 2014, 3:08 PM
dyatkovskiy added a comment to D3437: Fix a mergefunc crash caused by bitcasting intrinsics.

Hi Bjorn,
We have replaced "enumerate" method with "cmpValues" + "cmpConstants". That was made as part of bigger improvement.
Now getBitcast is not called. But your test is really usefull.
So I would like to ask you try your test with trunk llvm version. I think it should work now. If so, I try to organize commit for you today.

Jun 5 2014, 2:16 PM

May 12 2014

dyatkovskiy added reviewers for D3646: PR19091, libcxxabi fix of wrong demangling of "operator>(int)" : mclow.lists, rsmith.

So guys, how do you find this fix?

May 12 2014, 10:44 AM

May 7 2014

dyatkovskiy added a comment to D3646: PR19091, libcxxabi fix of wrong demangling of "operator>(int)" .

I have the same opinion. IMHO, the best solution is to extend Db with information about what was parsed. But how we could solve it now? Is there any other ways to distinguish operator> from tail of "<some_operator>" ?

May 7 2014, 11:13 AM
dyatkovskiy retitled D3646: PR19091, libcxxabi fix of wrong demangling of "operator>(int)" from to PR19091, libcxxabi fix of wrong demangling of "operator>(int)" .
May 7 2014, 6:41 AM

Apr 25 2014

dyatkovskiy updated D3507: Darwin vararg parameters support in assembler macros.
Apr 25 2014, 5:01 AM
dyatkovskiy retitled D3507: Darwin vararg parameters support in assembler macros from to Darwin vararg parameters support in assembler macros.
Apr 25 2014, 5:00 AM

Apr 24 2014

dyatkovskiy closed D3315: PR18921, vmov part.

r207080
Thanks for reviews!

Apr 24 2014, 12:24 AM

Apr 23 2014

dyatkovskiy closed D3354: Integrated assembler. :vararg macro..

r206951
Thanks for reviews!

Apr 23 2014, 11:12 PM
dyatkovskiy accepted D3437: Fix a mergefunc crash caused by bitcasting intrinsics.

Its good to me! Sean, what do you think?

Apr 23 2014, 1:24 AM
dyatkovskiy added a comment to D3437: Fix a mergefunc crash caused by bitcasting intrinsics.

I have talked with Chandler in IRC. My last suggestion contradicts LLVM design, because constants should never been removed.
So, that means we better stay on your current solution. I would be glad if you fix the tests anyway ;-)
Thanks!

Apr 23 2014, 12:58 AM

Apr 22 2014

dyatkovskiy added a comment to D3437: Fix a mergefunc crash caused by bitcasting intrinsics.

So, getBitCast creates new Value (call it C3).
C3 is not equal to C1, but it still hangs in air.
Perhaps then just as another solution, we could do the next:

  1. Check for bitcast possibility
  2. Create bitcast (C3)
  3. Check whether C1 is equal to C3
  4. Get rid of C3.
Apr 22 2014, 11:55 PM
dyatkovskiy added a comment to D3437: Fix a mergefunc crash caused by bitcasting intrinsics.

Yes, it would be good if you increase test size. So we could be sure it will run whole the comparison routines.

Apr 22 2014, 11:33 PM
dyatkovskiy added a comment to D3437: Fix a mergefunc crash caused by bitcasting intrinsics.

It doesn't return true.

Apr 22 2014, 11:25 PM
dyatkovskiy added a comment to D3437: Fix a mergefunc crash caused by bitcasting intrinsics.

Björn,
I think the fix of canLosslesslyBitcasted could be only accepted in case, when functions are not bitcastable at all. But I think they are. At least you can define such bitcast in globals. So I think, we better do our best from MergeFunctions side, keep it stable, file a bug, so then we could work on it afterwards.

Apr 22 2014, 11:22 PM
dyatkovskiy added inline comments to D3437: Fix a mergefunc crash caused by bitcasting intrinsics.
Apr 22 2014, 11:12 PM
dyatkovskiy added a comment to D3437: Fix a mergefunc crash caused by bitcasting intrinsics.

Dotdash, thank you for working on it!

Apr 22 2014, 10:52 PM