Page MenuHomePhabricator

[CommandObjectCommands] Honor stop-command-source-on-error
ClosedPublic

Authored by JDevlieghere on May 1 2019, 3:02 PM.

Details

Summary

The problem with the command object is that we didn't differentiate between the boolean value not being set, and the value being set to either true or false. If the value isn't set, we'd calculate it in the command interpreter based on the global options. With the old approach, we'd always set the value to the default of the option, which is not what the user wanted.

Diff Detail

Event Timeline

JDevlieghere created this revision.May 1 2019, 3:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2019, 3:02 PM
Herald added subscribers: teemperor, jfb. · View Herald Transcript

Reduce test

JDevlieghere retitled this revision from Watchpoint test + stop-command-source-on-error fix combo to [CommandObjectCommands] Honor stop-command-source-on-error .
JDevlieghere edited the summary of this revision. (Show Details)

Add dedicated test

davide accepted this revision.May 1 2019, 4:54 PM

LGTM

This revision is now accepted and ready to land.May 1 2019, 4:54 PM
This revision was automatically updated to reflect the committed changes.